ci: fix generate.sh bug #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generate.sh had a problem with parsing master trivial
Mara3l
force-pushed
the
master
branch
22 times, most recently
from
74b754f to
20d3dce
Compare
hkad98
reviewed
Apr 29, 2024
- hugo had a wrong environment trivial
hkad98
reviewed
Apr 30, 2024
Comment on lines
+42
to
48
| # `htmltest` is after publishing, so we can see the artifact. | ||
| - name: "htmltest" | ||
| run: | | ||
| rm -f htmltest.sh | ||
| wget https://raw.githubusercontent.com/gooddata/gooddata-python-sdk/master/scripts/htmltest.sh | ||
| chmod +x ./htmltest.sh | ||
| ./htmltest.sh -c docs/.htmltest.yml docs/public |
There was a problem hiding this comment.
Nitpick: Is htmltest necessary for preview?
hkad98
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trivial