-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static msg types using msgspec
#311
Draft
goodboy
wants to merge
2
commits into
master
Choose a base branch
from
msgtypes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
added a commit
to pikers/piker
that referenced
this pull request
Jul 7, 2022
Syncs with goodboy/tractor#311 which is nowhere near ready and this approach didn't end up being as straight forward as hoped. We're going to need a top level `Msg`-boxing type/protocol in `tractor` first...
goodboy
added a commit
to pikers/piker
that referenced
this pull request
Jul 8, 2022
Syncs with goodboy/tractor#311 which is nowhere near ready and this approach didn't end up being as straight forward as hoped. We're going to need a top level `Msg`-boxing type/protocol in `tractor` first...
This was referenced Jul 8, 2022
goodboy
force-pushed
the
signint_saviour
branch
4 times, most recently
from
July 15, 2022 19:24
8cd8eb5
to
54af0d4
Compare
goodboy
force-pushed
the
signint_saviour
branch
5 times, most recently
from
August 2, 2022 16:18
d1ddfa4
to
2d387f2
Compare
Needs a rebase onto master. |
The greasy details are strewn throughout a `msgspec` issue: jcrist/msgspec#140 and specifically this code was mostly written as part of POC example in this comment: jcrist/msgspec#140 (comment) This work obviously pertains to our desire and prep for typed messaging and capabilities aware msg-oriented-protocols in #196, caps sec nods in I added a "wants to have" method to `Context` showing how I think we could offer a pretty neat msg-type-set-as-capability-for-protocol system.
goodboy
added
enhancement
New feature or request
discussion
experiment
Exploratory design and testing
IPC and transport
messaging
messaging patterns and protocols
labels
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
discussion
enhancement
New feature or request
experiment
Exploratory design and testing
IPC and transport
messaging
messaging patterns and protocols
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP typed msg layer using
msgspec
.Relates to:
Further motivation for the approach being taken is hashed out somewhat in jcrist/msgspec#140
still needs lootttsa work..