Clusters and hot tips #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
commented
Nov 2, 2021
| @@ -38,7 +38,7 @@ async def open_actor_cluster( | |||
| uid = tractor.current_actor().uid | |||
|
|
|||
| async def _start(name: str) -> None: | |||
| name = f'{name}.{uid}' | |||
There was a problem hiding this comment.
This looked super horrible/confusing if you actually printed it 😂
overclockworked64
approved these changes
Nov 2, 2021
goodboy
commented
Nov 2, 2021
docs/README.rst
Outdated
|
|
||
| for (name, portal) in portal_map.items(): | ||
| n.start_soon( | ||
| partial( |
There was a problem hiding this comment.
just realizing i guess we don't actually need the partial right?
goodboy
commented
Nov 2, 2021
examples/quick_cluster.py
Outdated
|
|
||
| for (name, portal) in portal_map.items(): | ||
| n.start_soon( | ||
| partial( |
There was a problem hiding this comment.
Yah, I had the partial() originally because I thought we needed to pass a name='blah' kwarg but we're actually auto-generating them unless a sequence is passed.
I'm wondering if we should tweak this api to allow passing in only the names: list[str] and if so then the helper makes only as many actors as there are names? Also, in the case where names is passed we probably shouldn't be doing this <parentname>.<childname> generation right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example and mirrors it in the readme.
I tweaked the auto-generated names for actors created with
open_actor_cluster()to be simpler (since they had this weird.uidstring thing going on) to be simply<parent_name>.<name>.Oh right, and started a little internal dev tips doc just for reminding myself of stuff.
It needs lots more content don't worry.