feat(sanity-plugin): use syncByID instead of byHandle

good-idea · May 28, 2020 · 46ebcb3 · 46ebcb3
1 parent 5a3b997
commit 46ebcb3
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 33 deletions.
diff --git a/packages/sanity-plugin/src/ShopifyTool/Sync/Sync.tsx b/packages/sanity-plugin/src/ShopifyTool/Sync/Sync.tsx
@@ -12,8 +12,7 @@ interface State {
 }
 
 export interface SyncRenderProps extends State {
-  syncProductByHandle: (handle: string) => Promise<void>
-  syncCollectionByHandle: (handle: string) => Promise<void>
+  syncItemByID: (id: string) => Promise<void>
   syncProducts: () => Promise<void>
   syncCollections: () => Promise<void>
   syncAll: () => Promise<void>
@@ -94,17 +93,10 @@ class SyncBase extends React.Component<Props, State> {
 
   /** Public Methods */
 
-  public syncProductByHandle = async (handle: string) => {
+  public syncItemByID = async (id: string) => {
     await this.reset()
     this.setState({ syncState: 'syncing' as 'syncing' })
-    this.props.syncingClient.syncProductByHandle(handle)
-    this.setState({ syncState: 'complete' as 'complete' })
-  }
-
-  public syncCollectionByHandle = async (handle: string) => {
-    await this.reset()
-    this.setState({ syncState: 'syncing' as 'syncing' })
-    this.props.syncingClient.syncProductByHandle(handle)
+    this.props.syncingClient.syncItemByID(id)
     this.setState({ syncState: 'complete' as 'complete' })
   }
 
@@ -131,18 +123,11 @@ class SyncBase extends React.Component<Props, State> {
 
   public render() {
     const { children } = this.props
-    const {
-      syncProductByHandle,
-      syncCollectionByHandle,
-      syncProducts,
-      syncCollections,
-      syncAll,
-    } = this
+    const { syncItemByID, syncProducts, syncCollections, syncAll } = this
 
     const renderProps = {
       ...this.state,
-      syncProductByHandle,
-      syncCollectionByHandle,
+      syncItemByID,
       syncProducts,
       syncCollections,
       syncAll,

diff --git a/packages/sanity-plugin/src/components/ShopifySourceCollectionPreview.tsx b/packages/sanity-plugin/src/components/ShopifySourceCollectionPreview.tsx
@@ -19,13 +19,13 @@ const ShopifySourceCollectionPreviewInner = ({
   const { value: syncStateValue } = syncState
   if (!value) return null
 
-  const syncCollectionByHandle = syncingClient
-    ? syncingClient.syncCollectionByHandle
+  const syncItemByID = syncingClient
+    ? syncingClient.syncItemByID
     : () => undefined
-  const { title, handle, description } = value
+  const { title, id, description } = value
 
   const reSync = async () => {
-    syncCollectionByHandle(handle)
+    syncItemByID(id)
   }
 
   if (syncState.context.error)

diff --git a/packages/sanity-plugin/src/components/ShopifySourceProductPreview.tsx b/packages/sanity-plugin/src/components/ShopifySourceProductPreview.tsx
@@ -20,12 +20,12 @@ const ShopifySourceProductPreviewInner = ({
   const { value: syncStateValue } = syncState
   if (!value) return null
 
-  const syncProductByHandle = syncingClient
-    ? syncingClient.syncProductByHandle
+  const syncItemByID = syncingClient
+    ? syncingClient.syncItemByID
     : () => undefined
   const {
     title,
-    handle,
+    id,
     tags,
     productType,
     availableForSale,
@@ -38,7 +38,7 @@ const ShopifySourceProductPreviewInner = ({
   }`
 
   const reSync = async () => {
-    syncProductByHandle(handle)
+    syncItemByID(id)
   }
 
   if (syncState.context.error)

diff --git a/packages/sanity-plugin/src/sanityDocuments/collection.tsx b/packages/sanity-plugin/src/sanityDocuments/collection.tsx
@@ -43,9 +43,9 @@ export const createCollectionDocument = ({
       {
         title: 'Title',
         name: 'title',
-        readOnly: true,
+        // readOnly: true,
         type: 'string',
-        hidden: true,
+        // hidden: true,
         ...namedFields.title,
       },
       {
@@ -80,7 +80,7 @@ export const createCollectionDocument = ({
         name: 'products',
         type: 'array',
         description: 'Synced from Shopify',
-        readOnly: true,
+        // readOnly: true,
         of: [
           {
             type: 'reference',

diff --git a/packages/sanity-plugin/src/sanityDocuments/product.tsx b/packages/sanity-plugin/src/sanityDocuments/product.tsx
@@ -172,9 +172,9 @@ export const createProductDocument = ({
       {
         title: 'Title',
         name: 'title',
-        readOnly: true,
+        // readOnly: true,
         type: 'string',
-        hidden: true,
+        // hidden: true,
         ...namedFields.title,
       },
       {