Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot edit category name without select parent category #153

Closed
andretone opened this issue Nov 28, 2024 · 0 comments
Closed

Cannot edit category name without select parent category #153

andretone opened this issue Nov 28, 2024 · 0 comments

Comments

@andretone
Copy link

Describe the bug
For a category that not has parents, I cannot edit category name. "Please select an item in the list" in Parent box.

To Reproduce
Steps to reproduce the behavior:

  1. Login to Grimoire
  2. Category "+" to create a new category, create a new category without parents.
  3. Click on the new category, then click "Edit".
  4. Change category name, then click "Save"

Expected behavior
Category name will be changed.

Screenshots
image

Desktop (please complete the following information):

  • OS: Fedora 40 Linux
  • Firefox
  • Version 132.0.1 (64-bit)

Additional context
I'm using the latest release of Grimoire.
@gpoussel gpoussel mentioned this issue Dec 5, 2024
Merged
goniszewski added a commit that referenced this issue Dec 9, 2024
@gpoussel @goniszewski @Sparkenstein
Fix issue #153: creation/update of root categories (#157)
5e31e77 
* chore: release v0.4.3 (#149)

* chore: release v0.4.1-hotfix.3

* fix(data-migration): early return if no categories have parents (#128)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* Closes #130 (#131)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(database): use dynamic path for SQLite database file

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* docs(readme): use single README file for latest/preview version

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* feat(ci): add manual deployment workflow and adjust tag conditions

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* refactor(workflow): simplify manual-deploy GitHub Action

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(metadata): handle multiple image URLs in mainImageUrl field

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix: auth error handling (#144)

* refactor(api): migrate Swagger UI to external documentation and enhance health endpoint

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* chore: release v0.4.3

---------

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
Co-authored-by: Prabhanjan <zetabytes.pp@gmail.com>

* Fix creation/update of root categories

---------

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
Co-authored-by: Robert Goniszewski <43510122+goniszewski@users.noreply.github.com>
Co-authored-by: Prabhanjan <zetabytes.pp@gmail.com>
goniszewski added a commit that referenced this issue Dec 9, 2024
@goniszewski @Sparkenstein @gpoussel
chore: release v0.4.4 (#158)
df7971a 
* chore: release v0.4.1-hotfix.3

* fix(data-migration): early return if no categories have parents (#128)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* Closes #130 (#131)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(database): use dynamic path for SQLite database file

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* docs(readme): use single README file for latest/preview version

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* feat(ci): add manual deployment workflow and adjust tag conditions

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* refactor(workflow): simplify manual-deploy GitHub Action

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(metadata): handle multiple image URLs in mainImageUrl field

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix: auth error handling (#144)

* refactor(api): migrate Swagger UI to external documentation and enhance health endpoint

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* chore: release v0.4.3

* fix(docker): resolve issue with data directory permissions (#150)

* Fix issue #153: creation/update of root categories (#157)

* chore: release v0.4.3 (#149)

* chore: release v0.4.1-hotfix.3

* fix(data-migration): early return if no categories have parents (#128)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* Closes #130 (#131)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(database): use dynamic path for SQLite database file

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* docs(readme): use single README file for latest/preview version

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* feat(ci): add manual deployment workflow and adjust tag conditions

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* refactor(workflow): simplify manual-deploy GitHub Action

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(metadata): handle multiple image URLs in mainImageUrl field

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix: auth error handling (#144)

* refactor(api): migrate Swagger UI to external documentation and enhance health endpoint

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* chore: release v0.4.3

---------

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
Co-authored-by: Prabhanjan <zetabytes.pp@gmail.com>

* Fix creation/update of root categories

---------

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
Co-authored-by: Robert Goniszewski <43510122+goniszewski@users.noreply.github.com>
Co-authored-by: Prabhanjan <zetabytes.pp@gmail.com>

* Fix issue #145: bookmarks without images (#156)

* chore: release v0.4.3 (#149)

* chore: release v0.4.1-hotfix.3

* fix(data-migration): early return if no categories have parents (#128)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* Closes #130 (#131)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(database): use dynamic path for SQLite database file

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* docs(readme): use single README file for latest/preview version

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* feat(ci): add manual deployment workflow and adjust tag conditions

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* refactor(workflow): simplify manual-deploy GitHub Action

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(metadata): handle multiple image URLs in mainImageUrl field

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix: auth error handling (#144)

* refactor(api): migrate Swagger UI to external documentation and enhance health endpoint

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* chore: release v0.4.3

---------

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
Co-authored-by: Prabhanjan <zetabytes.pp@gmail.com>

* Fix bookmark creation/update without image

---------

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
Co-authored-by: Robert Goniszewski <43510122+goniszewski@users.noreply.github.com>
Co-authored-by: Prabhanjan <zetabytes.pp@gmail.com>

* chore: release v0.4.4

---------

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
Co-authored-by: Prabhanjan <zetabytes.pp@gmail.com>
Co-authored-by: Guillaume Poussel <gpoussel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andretone @goniszewski