Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gofaxsend into a package #58

Merged
merged 1 commit into from
May 27, 2021

Conversation

EtienneBruines
Copy link
Contributor

Using the idiomatic Go convention of writing code in a package,
and then handle the CLI in a smaller main-package.

This makes the code importable from other parts of the code and
more maintainable.

In the spirit of portability, also split SendQfile into a separate
function that uses the Qfile reference without requiring the use
of the filesystem.

Using the idiomatic Go convention of writing code in a package,
and then handle the CLI in a smaller main-package.

This makes the code importable from other parts of the code and
more maintainable.

In the spirit of portability, also split SendQfile into a separate
function that uses the Qfile reference without requiring the use
of the filesystem.
@denzs denzs merged commit c548bde into gonicus:master May 27, 2021
@denzs
Copy link
Member

denzs commented May 27, 2021

Thanks for your commit!
If you like, add another PR and add yourself to the AUTHORS file :)

@EtienneBruines EtienneBruines deleted the refactor_gofaxsend branch May 28, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants