Problem: no benchmarks #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: add a single one ```sh goos: linux goarch: amd64 pkg: github.com/gomoni/it cpu: AMD Ryzen 7 PRO 5850U with Radeon Graphics BenchmarkRangeFilter BenchmarkRangeFilter-16 448 2677041 ns/op BenchmarkRangeFilter-16 435 2665242 ns/op BenchmarkRangeFilter-16 442 2674867 ns/op BenchmarkRangeFilter-16 432 2718882 ns/op BenchmarkRangeFilter-16 408 2732315 ns/op BenchmarkItFilterSlice BenchmarkItFilterSlice-16 12 89357678 ns/op BenchmarkItFilterSlice-16 12 89829099 ns/op BenchmarkItFilterSlice-16 12 90112402 ns/op BenchmarkItFilterSlice-16 12 89383558 ns/op BenchmarkItFilterSlice-16 12 90150032 ns/op BenchmarkItFilterFor BenchmarkItFilterFor-16 19 58248848 ns/op BenchmarkItFilterFor-16 19 58173282 ns/op BenchmarkItFilterFor-16 18 58722532 ns/op BenchmarkItFilterFor-16 19 58333300 ns/op BenchmarkItFilterFor-16 19 58699434 ns/op PASS ok github.com/gomoni/it 19.939s michal@90michal:~/projects/gomoni/it> ```
|
Latest fix with new benchmarks results is #10 and penalty for using iterators now is so much smaller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: add a single one