Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart] fix deployment.yaml for enabled ssh git servers #1423

Closed
wants to merge 1 commit into from

Conversation

SergeyRolich
Copy link
Contributor

What is the problem I am trying to address?

If storage type not equals "disk" also need check sshGitServers and gitconfig

How is the fix applied?

Add check shGitServer and gitConfig for creating volumeMounts

Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.

Fixes #1367

@SergeyRolich SergeyRolich requested a review from a team as a code owner October 17, 2019 10:20
@DuplicatePR-bot
Copy link

Hi there! This pull request looks like it might be a duplicate of #1370, since it has the same issue number , a similar title, and similar commits.

To improve our bot, you can help us out by clicking one of the options below:
- This pull request is a duplicate, so this comment was useful. check
- This pull request is not a duplicate, but this comment was useful nevertheless. check
- This pull request is not a duplicate, so this comment was not useful. check
- I do not need this service, so this comment was not useful. check

This bot is currently in its alpha stage, and we are only sending at most one comment per repository. If you are interested in using our bot in the future, please subscribe. If you would like to learn more, see our web page.

@SergeyRolich
Copy link
Contributor Author

Duplicate #1370, close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment to kubernets
2 participants