Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added homebrew release to .goreleaser.yml #26

Merged
merged 2 commits into from
Feb 20, 2021
Merged

Added homebrew release to .goreleaser.yml #26

merged 2 commits into from
Feb 20, 2021

Conversation

brittonhayes
Copy link
Contributor

@brittonhayes brittonhayes commented Feb 18, 2021 •
edited
Loading

Description

  • Added support for homebrew in the goreleaser config
  • Homebrew tap will be released to gomatic/homebrew-renderizer in the Forumula folder

Hope this is helpful!

@nicerobot nicerobot self-assigned this Feb 18, 2021
@nicerobot
Copy link
Member

Thanks. I should be able to get to this and my action items Friday or Saturday at the latest.

nicerobot
nicerobot approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@nicerobot nicerobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. I've bever submitted a tab. Does the commit_author need to align with a GitHub user and should the email be real? Maybe i'll learn this as i handle my action items.

@nicerobot
Copy link
Member

Closes #25

@nicerobot nicerobot merged commit 8e642c2 into gomatic:master Feb 20, 2021
@nicerobot nicerobot linked an issue Feb 20, 2021 that may be closed by this pull request
Homebrew release of renderizer #25
Closed
@brittonhayes
Copy link
Contributor Author

brittonhayes commented Feb 20, 2021 •
edited
Loading

Seems reasonable to me. I've bever submitted a tab. Does the commit_author need to align with a GitHub user and should the email be real? Maybe i'll learn this as i handle my action items.

@nicerobot I've never personally don't it with a real email. I always do the no reply GitHub one for privacy on commit messages. It should essentially match whatever you prefer your commit author in normal git to be.

Also, thanks for merging! Excited to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicerobot nicerobot nicerobot approved these changes

Assignees

@nicerobot nicerobot

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Homebrew release of renderizer
2 participants
@brittonhayes @nicerobot