Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring improvements #91

Merged
merged 4 commits into from
May 18, 2023
Merged

Spring improvements #91

merged 4 commits into from
May 18, 2023

Conversation

golles
Copy link
Owner

@golles golles commented May 18, 2023

  • Single instance restriction has been removed
  • Improve translations for error messages
  • Improve develop script, to not reset the dev container every restart
  • Add update script, to update all dependencies, including test dependencies
  • Improve tests (eg. a fix Lingering timers)
  • Implement upstream changes
    • Coordinator code moved to coordinator.py

golles added 4 commits April 3, 2023 20:10
Use fixures
Fix: PytestDeprecationWarning: The hookimpl CovPlugin.pytest_testnodedown uses old-style configuration options
- Single instance restriction has been removed
- Improve translations for error messages
- Improve `develop` script, to not reset the dev container every restart
- Add `update` script, to update all dependencies, including test dependencies
- Improve tests (eg. a fix Lingering timers)
- Implement upstream changes
  - Coordinator code moved to `coordinator.py`
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 75.58% and project coverage change: -16.39 ⚠️

Comparison is base (9f3997d) 75.69% compared to head (a9d5420) 59.31%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #91       +/-   ##
===========================================
- Coverage   75.69%   59.31%   -16.39%     
===========================================
  Files           7        8        +1     
  Lines         358      349        -9     
===========================================
- Hits          271      207       -64     
- Misses         87      142       +55     
Impacted Files Coverage Δ
custom_components/kamstrup_403/const.py 100.00% <ø> (ø)
custom_components/kamstrup_403/diagnostics.py 0.00% <0.00%> (ø)
custom_components/kamstrup_403/coordinator.py 67.34% <67.34%> (ø)
custom_components/kamstrup_403/config_flow.py 92.10% <82.35%> (-3.55%) ⬇️
custom_components/kamstrup_403/__init__.py 100.00% <100.00%> (+13.79%) ⬆️
...tom_components/kamstrup_403/pykamstrup/kamstrup.py 14.28% <100.00%> (-38.35%) ⬇️
custom_components/kamstrup_403/sensor.py 97.14% <100.00%> (+2.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@golles
Copy link
Owner Author

golles commented May 18, 2023

The drop in test coverage isn't satisfying and will be improved later. This PR will be merged as this will unblock #86 #88 and #90

@golles golles merged commit 8c2f87a into main May 18, 2023
@golles golles deleted the spring-improvements branch May 18, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant