Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang format: Remove Cpp language specifier #757

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

trond-snekvik
Copy link
Contributor

clang-format 20.1.0 adds C as a language instead of treating it as C++. This breaks our clang-format configuration, which scopes the configuration to Cpp at the start of the config file, making the lint action claim that C isn't supported by the configuration.

Example failure in CI: https://github.com/golioth/golioth-firmware-sdk/actions/runs/13788107438/job/38560847890

clang-format 20.1.0 adds C as a language instead of treating it as C++.
This breaks our clang-format configuration, which scopes the
configuration to CPP at the start of the config file, making the lint
action claim that C isn't supported by the configuration.

Signed-off-by: Trond Snekvik <trond@golioth.io>
@trond-snekvik trond-snekvik requested a review from mniestroj March 12, 2025 11:22
Copy link

Visit the preview URL for this PR (updated for commit 7fbd616):

https://golioth-firmware-sdk-doxygen-dev--pr757-clang-format-2-9m9plcu2.web.app

(expires Wed, 19 Mar 2025 11:28:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9993e61697a3983f3479e468bcb0b616f9a0578

@trond-snekvik trond-snekvik merged commit b52816c into main Mar 12, 2025
133 of 139 checks passed
@trond-snekvik trond-snekvik deleted the clang-format-20-language branch March 12, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants