tests: hil: scripts: package plugins in directories #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 31947cd): https://golioth-firmware-sdk-doxygen-dev--pr749-pytest-plugin-lrmi3j1l.web.app (expires Tue, 04 Mar 2025 01:10:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
szczys
approved these changes
Feb 24, 2025
We were previously packaging our HIL pytest plugins as collections of python scripts without any directory hierarchy. This meant that every python file in the package was placed in the root of the site_packages directory. If any other package did the same and had names that conflicted, the files would be overwritten. For example these two plugins both contain a file named plugin.py and both attempt to place that file at the root of the site packages directory. Normal practice in python is to create a directory for each package, and that's what's done in this commit. Signed-off-by: Sam Friedman <sam@golioth.io>
sam-golioth
force-pushed
the
pytest_plugin_packages
branch
from
9d05377 to
31947cd
Compare
Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously packaging our HIL pytest plugins as collections of python scripts without any directory hierarchy. This meant that every python file in the package was placed in the root of the site_packages directory. If any other package did the same and had names that conflicted, the files would be overwritten. For example these two plugins both contain a file named plugin.py and both attempt to place that file at the root of the site packages directory. Normal practice in python is to create a directory for each package, and that's what's done in this commit.
Before:
After: