Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1971: Cleaning up client after upgrading to v1.5 #423

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk self-assigned this Sep 24, 2024
Copy link

linear bot commented Sep 24, 2024

@jmikolajczyk jmikolajczyk changed the title oct-1971: client refactor 1 OCT-1971: Cleaning up client after upgrading to v1.5 Sep 25, 2024
@jmikolajczyk jmikolajczyk marked this pull request as ready for review September 25, 2024 11:33
@jmikolajczyk jmikolajczyk merged commit 4b6203f into feature/oct-1857-octant-client-v1.5 Sep 25, 2024
31 checks passed
@jmikolajczyk jmikolajczyk deleted the refactor/oct-1971-cleaning-up-client branch September 25, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants