Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-1714 API Tests: Implement tests for epoch4 with capped QF (allocations) #395

Merged
merged 6 commits into from
Sep 2, 2024
Merged

OCT-1714 API Tests: Implement tests for epoch4 with capped QF (allocations) #395

merged 6 commits into from
Sep 2, 2024

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@kgarbacinski kgarbacinski self-assigned this Aug 26, 2024
@aziolek aziolek changed the title OCT-1714: Check allocation for changes introduced in E4 OCT-1714 API Tests: Implement tests for epoch4 with capped QF (allocations) Aug 26, 2024
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Aug 28, 2024
@kgarbacinski kgarbacinski added request-approval Request approval from the Housekeeper and removed request-approval Request approval from the Housekeeper labels Aug 29, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 29, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10611711395 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Aug 29, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 29, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10618322536 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Aug 29, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 29, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10619494178 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Sep 2, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Sep 2, 2024
housekeeper-bot
housekeeper-bot approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10667275397 passed 🎉

@kgarbacinski kgarbacinski merged commit bceb433 into develop Sep 2, 2024
92 of 95 checks passed
@kgarbacinski kgarbacinski deleted the kacper/feat/oct-1714-implement-tests-for-qf-e4 branch September 2, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulperegud paulperegud paulperegud approved these changes

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@MateuszStoleckiGLM MateuszStoleckiGLM MateuszStoleckiGLM approved these changes

@adam-gf adam-gf Awaiting requested review from adam-gf

Assignees

@kgarbacinski kgarbacinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kgarbacinski @paulperegud @housekeeper-bot @MateuszStoleckiGLM @mike-code