Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1597 Implement automated sanity tests for History endpoint #369

Merged

Conversation

MateuszStoleckiGLM
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@MateuszStoleckiGLM MateuszStoleckiGLM force-pushed the feature/OCT-1597-history-api-sanity-test branch 2 times, most recently from 52ad967 to 52c3972 Compare July 30, 2024 13:39
@MateuszStoleckiGLM MateuszStoleckiGLM self-assigned this Jul 30, 2024
kgarbacinski
kgarbacinski previously approved these changes Jul 31, 2024
Signed-off-by: Mateusz Stolecki <mateusz@golem.foundation>

Signed-off-by: Mateusz Stolecki <mateusz@golem.foundation>
@MateuszStoleckiGLM MateuszStoleckiGLM force-pushed the feature/OCT-1597-history-api-sanity-test branch from 3b5fcad to 0c207ba Compare August 7, 2024 12:35
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Aug 7, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 7, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10284423457 passed 🎉

@MateuszStoleckiGLM MateuszStoleckiGLM merged commit 381c857 into develop Aug 8, 2024
38 checks passed
@MateuszStoleckiGLM MateuszStoleckiGLM deleted the feature/OCT-1597-history-api-sanity-test branch August 8, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants