Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Runtime usage counters #4901

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Runtime usage counters #4901

merged 2 commits into from
Dec 4, 2019

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Nov 18, 2019

Defined a set of common counters for Runtime objects. Implemented the counters for Docker environment.

Do not merge. It's not supposed to go into 0.22 release.

@Wiezzel Wiezzel self-assigned this Nov 18, 2019
@Wiezzel Wiezzel force-pushed the usage_counters branch 9 times, most recently from 65ca07f to d951738 Compare November 21, 2019 13:52
@Wiezzel Wiezzel added the clay label Nov 21, 2019
@Wiezzel
Copy link
Author

Wiezzel commented Nov 21, 2019

@mfranciszkiewicz @maaktweluit Please review. It's a draft because I don't want to merge it to b0.22. Will make a proper PR once b0.22 is merged to develop.

Copy link
Contributor

@mfranciszkiewicz mfranciszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. One small doubt about the stability of stream

@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #4901 into develop will decrease coverage by 0.95%.
The diff coverage is 91.54%.

@@             Coverage Diff             @@
##           develop    #4901      +/-   ##
===========================================
- Coverage    90.07%   89.12%   -0.96%     
===========================================
  Files          233      233              
  Lines        21598    21660      +62     
===========================================
- Hits         19454    19304     -150     
- Misses        2144     2356     +212

@Wiezzel Wiezzel changed the base branch from b0.22 to develop December 2, 2019 14:20
Defined a set of common counters for Runtime objects. Implemented the
counters for Docker environment.

Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Adjusted assertions for RAM and CPU.
Marked tests as slow for they are such (>5s each).

Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
@Wiezzel Wiezzel marked this pull request as ready for review December 2, 2019 14:23
@Wiezzel Wiezzel merged commit efa62ca into develop Dec 4, 2019
@Wiezzel Wiezzel deleted the usage_counters branch December 4, 2019 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants