Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Upgrade to Task API v0.20.0 #4770

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Upgrade to Task API v0.20.0 #4770

merged 1 commit into from
Sep 26, 2019

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Sep 25, 2019 •
edited
Loading

  • Return VerifyStatus instead of bool from verify method.
  • Use dirtuils for managing requestor and provider directories.

@Wiezzel Wiezzel force-pushed the task_api_dirutils branch 5 times, most recently from 17c2918 to 3362d2e Compare September 25, 2019 12:17
@Wiezzel Wiezzel changed the title Use dirutils introduced in Task API v0.20.0 Upgrade to Task API v0.20.0 Sep 25, 2019
@Wiezzel Wiezzel requested a review from maaktweluit September 25, 2019 15:13
@Wiezzel Wiezzel self-assigned this Sep 25, 2019
@Wiezzel Wiezzel marked this pull request as ready for review September 25, 2019 15:14
@Wiezzel Wiezzel added the clay label Sep 25, 2019
maaktweluit
maaktweluit suggested changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One small q, approve on reply or solve :)

@Wiezzel
Upgrade to Task API v0.20.0
bd7eab3 
* Return VerifyStatus instead of bool from verify method.
* Use dirtuils for managing requestor and provider directories.
@Wiezzel Wiezzel requested a review from maaktweluit September 26, 2019 09:10
maaktweluit
maaktweluit approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@maaktweluit maaktweluit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Not sure if we need all those dirs as public functions, some might be only used by the RTM and then self._task_dir(...).some_dir would suffice

@codecov
Copy link

codecov bot commented Sep 26, 2019 •
edited
Loading

Codecov Report

Merging #4770 into develop will decrease coverage by 1.8%.
The diff coverage is 91.89%.

@@             Coverage Diff             @@
##           develop    #4770      +/-   ##
===========================================
- Coverage     89.3%   87.49%   -1.81%     
===========================================
  Files          211      211              
  Lines        19855    19840      -15     
===========================================
- Hits         17731    17359     -372     
- Misses        2124     2481     +357

@Wiezzel Wiezzel merged commit 3b4dfad into develop Sep 26, 2019
@Wiezzel Wiezzel deleted the task_api_dirutils branch September 26, 2019 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maaktweluit maaktweluit maaktweluit approved these changes

Assignees

@Wiezzel Wiezzel

Labels
clay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wiezzel @maaktweluit