Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

TaskHeaders and RequestedTaskManager #4730

Merged
merged 13 commits into from
Sep 18, 2019
Merged

Conversation

maaktweluit
Copy link
Contributor

Add RequestedTaskManager.get_task_headers() and send them to the network

Copy link
Contributor

@Krigpl Krigpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of putting the TaskHeaders dependency inside the RTM (vs doing the conversion outside the class) but I understand that's the easiest.

@maaktweluit maaktweluit changed the title TaskHeaders in RequestedTaskManager TaskHeaders and RequestedTaskManager Sep 17, 2019
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #4730 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4730      +/-   ##
===========================================
+ Coverage     89.3%   89.32%   +0.01%     
===========================================
  Files          211      211              
  Lines        19822    19842      +20     
===========================================
+ Hits         17703    17724      +21     
+ Misses        2119     2118       -1

Copy link
Contributor

@Krigpl Krigpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@maaktweluit maaktweluit merged commit 7e0a2d7 into develop Sep 18, 2019
@maaktweluit maaktweluit deleted the mwu/rtm-task-headers branch September 18, 2019 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants