This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krigpl
reviewed
Sep 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of putting the TaskHeaders dependency inside the RTM (vs doing the conversion outside the class) but I understand that's the easiest.
95e51fd
to
d923598
Compare
Krigpl
reviewed
Sep 17, 2019
Wiezzel
approved these changes
Sep 17, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4730 +/- ##
===========================================
+ Coverage 89.3% 89.32% +0.01%
===========================================
Files 211 211
Lines 19822 19842 +20
===========================================
+ Hits 17703 17724 +21
+ Misses 2119 2118 -1 |
Krigpl
reviewed
Sep 17, 2019
Krigpl
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
mfranciszkiewicz
approved these changes
Sep 17, 2019
89661f0
to
b6937b0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RequestedTaskManager.get_task_headers()
and send them to the network