Revert "Enable json serializer in crossbar router"

[etam]

This reverts commit 51d8a97.

This was introduced in #3926, but it's not needed anymore.

[shadeofblue]

@etam please rebase that against develop -> it's not important for this release

[etam]

rebased

[kmazurek]

[codecov]

Codecov Report

Merging #4656 into develop will increase coverage by 1.18%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4656      +/-   ##
===========================================
+ Coverage    89.08%   90.27%   +1.18%     
===========================================
  Files          211      211              
  Lines        19717    19667      -50     
===========================================
+ Hits         17565    17754     +189     
+ Misses        2152     1913     -239

[etam]

Somehow this change is making integration tests fail with ReactorAlreadyInstalledError. I can reproduce this on my PC.

[etam]

It fails, because I removed importing golem.rpc.router from golemapp.py. Which is totally weird and it shouldn't behave like that.

[etam]

I pinned down a bit this twisted weird behavior: In golem/network/hyperdrive/client.py there is from twisted.web.client import readBody, which internally does from twisted.internet import [...] reactor. This installs default reactor. Somehow importing golem.rpc.router in golemapp.py inhibits installing reactor.

Edit: import golem.rpc.router can be replaced by more precise import crossbar.personality.

[mfranciszkiewicz]

@etam Also from twisted.web.client import readBody can be safely converted to a local import in _async_request

[etam]

@etam Also from twisted.web.client import readBody can be safely converted to a local import in _async_request

This seems to be not enough. I've made a workaround for now. Let's resolve this in a separate task.