This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Task API computation flow #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
force-pushed
the
new_taskcomputer
branch
from
11e053d to
cadc186
Compare
Wiezzel
reviewed
Jul 31, 2019
maaktweluit
reviewed
Aug 8, 2019
| @@ -1163,6 +1182,30 @@ def test_already_assigned( | |||
| dispatcher_mock.send.assert_not_called() | |||
| logger_mock.error.assert_called() | |||
|
|
|||
| def test_task_api( | |||
| self, _logger_mock, _dispatcher_mock, | |||
There was a problem hiding this comment.
one argument per line from the style guide
|
@maaktweluit I consider the threading issue resolved. |
Codecov Report
@@ Coverage Diff @@
## develop #4561 +/- ##
===========================================
- Coverage 90.33% 90.33% -0.01%
===========================================
Files 225 225
Lines 19929 19944 +15
===========================================
+ Hits 18003 18016 +13
- Misses 1926 1928 +2 |
Wiezzel
approved these changes
Aug 12, 2019
|
@Krigpl Please create a follow-up PR solving the |
|
@mfranciszkiewicz Didn't you find that this runs in a separate thread anyway so it doesn't effectively matter much anyway at the moment? |
|
@Krigpl ATM it runs in a separate thread through |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another two if conditions.