This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fix GNT conversion when there's GNT top up in the meantime #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
shadeofblue
reviewed
Feb 26, 2019
golem/ethereum/transactionsystem.py
Outdated
| @@ -108,7 +108,7 @@ def __init__(self, datadir: Path, config) -> None: | |||
| self._payment_processor: Optional[PaymentProcessor] = None | |||
|
|
|||
| self._gnt_faucet_requested = False | |||
| self._gnt_conversion_status = ConversionStatus.NONE | |||
| self._gnt_conversion_status = (ConversionStatus.NONE, None) | |||
There was a problem hiding this comment.
@Krigpl it would be good to either add a type hint for the second value or maybe just add a comment what it is when not None ...
Codecov Report
@@ Coverage Diff @@
## b0.19 #3923 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.02%
==========================================
Files 205 205
Lines 18310 18314 +4
==========================================
+ Hits 16337 16345 +8
+ Misses 1973 1969 -4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when one topped up the account twice in quick succession the second amount of GNT would not convert.
That is fixed now.