This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Create DockerWhitelist class #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mfranciszkiewicz
approved these changes
Mar 25, 2019
Codecov Report
@@ Coverage Diff @@
## epic/env_refactor #3860 +/- ##
====================================================
Coverage ? 88.82%
====================================================
Files ? 221
Lines ? 19227
Branches ? 0
====================================================
Hits ? 17078
Misses ? 2149
Partials ? 0 |
Wiezzel
force-pushed
the
docker_whitelist
branch
from
0a1772b to
bce0e2a
Compare
Wiezzel
force-pushed
the
docker_whitelist
branch
from
bce0e2a to
62f3321
Compare
* Updated schema version to 26 * Insert 'golemfactory' by default into the database * Changed is_whitelisted() to accept image_name which seems more convenient to use
Krigpl
force-pushed
the
docker_whitelist
branch
from
95e9bb3 to
159b454
Compare
Wiezzel
approved these changes
Apr 24, 2019
| @@ -309,6 +310,12 @@ def test_env_disabled(self): | |||
| with self.assertRaises(ValueError): | |||
| self.env.install_prerequisites(prereqs) | |||
|
|
|||
| def _patch_whitelist(self, return_value): | |||
| # Has to use twisted's patch because standard one doesn't work with | |||
| # Deferreds very well | |||
There was a problem hiding this comment.
You could have used the same approach as I did with local_client in test_pull_image_error but this looks just as good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just per repository since tags are mutable so it's not secure in this sense. Alternatively, we can use image IDs which are not user-friendly.