This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Skip the async_run call in NetworkConnectionPublisherService #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be cleaner to pass a |
Codecov Report
@@ Coverage Diff @@
## b0.16.0 #2849 +/- ##
==========================================
+ Coverage 90% 90% +<.01%
==========================================
Files 186 186
Lines 16220 16222 +2
==========================================
+ Hits 14598 14601 +3
+ Misses 1622 1621 -1 |
|
Refactoring |
maaktweluit
approved these changes
Jun 5, 2018
There was a problem hiding this comment.
LGTM!
Would propose to make an new issue to be solved later for @etam s idea!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2834