Refactor rule parser #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All type inferring was grouped in "scope.js" and most evaluation code was grouped in "rule.js". Now that type inferring is some time delayed until runtime evaluation, it doesn't make sense to separate them; they have been merged. The parser code have been split by expression type instead; it would have been too long in one script.
We save live firebase evaluation in a JSON file (and commit it) and run test against them. The alternative of running targaryen and live test in parallel would take too long. The cron job should be run everyday to make sure Firebase evaluation hasn’t change (TODO).
dinoboff
force-pushed
the
refactor-parser
branch
from
e1a382b to
a144ac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All type inferring code was grouped in "scope.js" and most evaluation code was grouped in "rule.js". Now that type inferring is some times delayed until runtime evaluation, it doesn't make sense to separate them; they have been merged.
The parser code have been split by expression type instead; it would have been too long in one script.
To update the parser/evaluator rules against Firebase specs, it also add a script to record rule parsing and evaluation on Firebase. Each rule get deployed; it then attempt to read a path that will trigger the rule evaluation and save the result. If the result is false it will insure it didn't evaluate to false because of a runtime error.
Fix #89 #63