Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of arguments with wrong type in snapshot and string methods. #87

Merged
merged 2 commits into from
Nov 15, 2016

Conversation

dinoboff
Copy link
Collaborator

@dinoboff dinoboff commented Nov 15, 2016

  • fix snapshot methods.
  • fix string methods.

Fix #86

@dinoboff
Copy link
Collaborator Author

dinoboff commented Nov 15, 2016

Actually, snapshot behave the same than string methods:

  • root.child("foo").child(auth.foo).exists() with auth.foo == null evaluate to false
  • root.child("foo").child(auth.foo).exists() == false with auth.foo == null evaluate to false

I will fix the fix to throw when the snapshot methods receive anything else than strings.

Both `’foo’.contains(auth.foo)` and `’foo’.contains(auth.foo) == false` most evaluate to false. With the current design, it means the string methods must throw.
@dinoboff dinoboff changed the title Fix handle null value by snapshot and string methods. Fix handling of type error arguments by snapshot and string methods. Nov 15, 2016
@dinoboff dinoboff changed the title Fix handling of type error arguments by snapshot and string methods. Fix handling of arguments with wrong type in snapshot and string methods. Nov 15, 2016
@dinoboff dinoboff merged commit feea9cf into goldibex:next Nov 15, 2016
@dinoboff dinoboff deleted the fix-null-value-handling branch November 15, 2016 13:42
@dinoboff dinoboff added this to the 3.0 milestone Nov 15, 2016
@dinoboff dinoboff mentioned this pull request Dec 14, 2016
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant