-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
newData should contain all the merged data #108
Comments
Note that when the newData holds any value, like if we were trying to update the |
Thanks for the report. I could reproduce it and I am working on a fix. |
ps: note that newData reference the all new tree; one location in that tree. It seems there's a bug where the parent node got deleted instead of just |
@georgesboris It should be fixed in 3.0.0-rc.4. Thanks. |
Hey man, thanks for developing this.
We've been trying to use targaryan for a while now with my team.
Although it helps a lot we're encountering some issues, specially since the updates made recently.
Take a look at this for instance.
In Firebase, when you update some paths, the newData holds all the information for the current tree, not only the information that is been sent.
Like so:
When trying to do the same with targaryan:
I will try to post here when we find any other issues.
And we will gladly contribute to their solutions, it's just that we're in a crazy end of year sprint.
We're kind of being forced to "let the tests slip for a while" instead of being allowed to fix this.
The text was updated successfully, but these errors were encountered: