Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newData should contain all the merged data #108

Closed
georgesboris opened this issue Dec 22, 2016 · 4 comments
Closed

newData should contain all the merged data #108

georgesboris opened this issue Dec 22, 2016 · 4 comments
Milestone

Comments

@georgesboris
Copy link
Contributor

georgesboris commented Dec 22, 2016

Hey man, thanks for developing this.

We've been trying to use targaryan for a while now with my team.
Although it helps a lot we're encountering some issues, specially since the updates made recently.

Take a look at this for instance.

In Firebase, when you update some paths, the newData holds all the information for the current tree, not only the information that is been sent.

Like so:

captura de tela 2016-12-22 as 4 49 46 pm

captura de tela 2016-12-22 as 4 45 41 pm

When trying to do the same with targaryan:

captura de tela de 2016-12-22 16-43-08

I will try to post here when we find any other issues.
And we will gladly contribute to their solutions, it's just that we're in a crazy end of year sprint.
We're kind of being forced to "let the tests slip for a while" instead of being allowed to fix this.

@georgesboris
Copy link
Contributor Author

Note that when the newData holds any value, like if we were trying to update the createdBy prop instead of passing null to it, it appears to work as expected.

dinoboff added a commit to dinoboff/targaryen that referenced this issue Dec 23, 2016
@dinoboff
Copy link
Collaborator

Thanks for the report. I could reproduce it and I am working on a fix.

@dinoboff
Copy link
Collaborator

dinoboff commented Dec 23, 2016

ps: note that newData reference the all new tree; one location in that tree. It seems there's a bug where the parent node got deleted instead of just createdBy.

dinoboff added a commit to dinoboff/targaryen that referenced this issue Dec 23, 2016
dinoboff added a commit to dinoboff/targaryen that referenced this issue Dec 23, 2016
@dinoboff dinoboff added this to the 3.0.0 milestone Dec 23, 2016
@dinoboff
Copy link
Collaborator

dinoboff commented Dec 23, 2016

@georgesboris It should be fixed in 3.0.0-rc.4.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants