Added 'Native methods Over Util' article #305

Berkmann18 · 2018-12-25T15:48:12Z

This PR adds the "Prefer native JS methods over user-land utils like Lodash" article (including the inclusion in the README).

re #302

…mistake Rename file to correct mistake

Minor change-lower case to title case

goldbergyoni · 2018-12-27T15:02:02Z

@sagirk @BrunoScheufler @js-kyle

Since it's the first perf BP in collaboration with a contributor, I'd like to all of your thoughts on how to smoothen this process. Specifically, what should we emphasize in our writing guidelines to minimize back and forth?

@BrunoScheufler What about our linter? 😠 😄

Minor text change- lower case to title case

README.md

BrunoScheufler

Looks great so far, I've got some small recommendations to content changes, otherwise good to go!

sections/performance/nativeoverutil.md

+Removing original eng text +Fix wired Expression

Co-Authored-By: Berkmann18 <maxieberkmann@gmail.com>

Berkmann18 · 2018-12-29T10:03:58Z

@BrunoScheufler I applied the changes you requested.

BrunoScheufler

👍

BrunoScheufler · 2018-12-29T21:05:53Z

@Berkmann18 thanks for your contribution!

@i0natan I think this is good to go, what do you think? If you agree, you can simply merge it 😄

Berkmann18 · 2018-12-30T15:41:44Z

@BrunoScheufler You're welcome 😄.

goldbergyoni

@Berkmann18 Looks like a promising start and also a piece of valuable advice that is easy to implement. The linter example is a killer 👏

Let's take it 1 level up together, sharpen the messages and learn new things. We might need 1-2 iterations to finalize this bullet.

See my remarks within the text, let me know your thoughts 🙏

goldbergyoni · 2019-01-01T07:28:16Z

README.md

+
+ **TL;DR:** It's often more penalising to use utility libraries like `lodash` and `underscore` over native methods as it leads to unneeded dependencies and slower performance.
+
+**Otherwise:** You'll have to maintain (slightly) bigger projects where you could have simply used what was **already** available or dealt with a few more lines in exchange of a few more files.


@Berkmann18 Since ~97% of a typical project is 3rd party, I don't think the major downside is the bigger package. Considering that it's also a performance section - I would just emphasize here the degraded performance

Sure, I've done that.
Is this:

You'll have to maintain less performant projects where you could have simply used what was already available or dealt with a few more lines in exchange of a few more files.

Fine?

@Berkmann18 Is this the opening sentence?

It's the sentence for the "Otherwise" section.

README.md

goldbergyoni · 2019-01-01T07:43:05Z

sections/performance/nativeoverutil.md

+
+### One Paragraph Explainer
+
+Sometimes, using native methods is better than requiring `lodash` or `underscore` because the resulting program will have more dependencies and thus use more space and also not guarantee the best performance all-round.


@Berkmann18 I would focus on the performance gain with examples and numbers, this is a performance section. The opening paragraph is right to some extent but should be secondary to the performance improvement idea

I've taken that into account and simplified the paragraph which emphasises the performance loss.

sections/performance/nativeoverutil.md

goldbergyoni · 2019-01-01T07:54:38Z

sections/performance/nativeoverutil.md

+
+<br/><br/>
+
+### Code Example – Benchmark test on `_.concat`/`Array.concat`


@Berkmann18 Important: This example is very long (see bullet 1 here), we can make the point using more concise examples and visuals:

Example: v8 native engine vs Lodash - 4 lines example that shows lodash method and below the v8 alternative

Optional: Example: some other title - longer example with more methods

Example: benchmark comparison - Lodash vs V8: A graph image showing the performance differences

@Berkmann18 At your own convenience, try thinking how to shorten and sharpen this example. I know how hard it's, found myself more than a few times trying to cut in a half a complex code sample

I found a way to shorten that example without hiding too much (say, if someone were to copy-paste the code without missing necessary bits).
And I kept the _.concat code example while adding a section with a graph on the Lodash vs V8 example you gave.

sections/performance/nativeoverutil.md

fix npm link

Update README.chinese.md

README.md

Improved the examples and swapped some text with images.

goldbergyoni

@Berkmann18 It's now even better, the graphs and the examples are concise and sharper 🎖

Le'ts have a last short iteration, see my comments, I'm tuned to approve it once you flag that the changes are ready

Most of the issues are formatting issues, it's not consistent enough with how other bullets look like, kindly have a look at other quotes/code-examples and try to unify

README.md

sections/performance/nativeoverutil.md

goldbergyoni · 2019-01-09T07:49:40Z

sections/performance/nativeoverutil.md

+### Example: benchmark comparison - Lodash vs V8 (Native)
+The graph below shows the mean of the benchmarks for a variety of Lodash methods, this shows that Lodash methods take on average 146.23% more time to complete the same tasks as V8 methods.
+
+![meanDiag](../../assets/images/sampleMeanDiag.png)


Let's include a link to the article?

I've added a link to the relevant spreadsheet if that's fine?

sections/performance/nativeoverutil.md

goldbergyoni · 2019-01-09T07:57:29Z

sections/performance/nativeoverutil.md

+
+ > Lodash and Underscore are great modern JavaScript utility libraries, and they are widely used by Front-end developers. However, when you are targeting modern browsers, you may find out that there are many methods which are already supported natively thanks to ECMAScript5 [ES5] and ECMAScript2015 [ES6]. If you want your project to require fewer dependencies, and you know your target browser clearly, then you may not need Lodash/Underscore.
+
+ There's also an [ESLint plugin](https://www.npmjs.com/package/eslint-plugin-you-dont-need-lodash-underscore) which detects where you're using libraries but don't need to.


Create a new section, new paragraph, new Example: Linting for non-native methods usage. Separate this from the quote @Berkmann18

Okay, I've revisited in that part and the example below that part to make it coherent.

December 2018 maintenance

…into dev

goldbergyoni · 2019-01-14T08:58:34Z

@Berkmann18 Perfect. A star will be assigned by the end of January #318 🏅

I will also Tweet this new BP today.

Hope to see you here again soon :]

Berkmann18 · 2019-01-14T09:12:22Z

Woo! I'm glad I contributed and look forward to contributing more.

Added 'Native methods Over Util' article

Berkmann18 and others added 7 commits December 25, 2018 15:46

Added 'Native methods Over Util' article

ea7617c

Change links from producton to production

6851959

Rename readme files from producton to production

6a6acb2

Link to english version as korean version of the document does not exist

190ceaa

Merge pull request goldbergyoni#306 from HeeL/rename-file-to-correct-…

9835667

…mistake Rename file to correct mistake

Minor change-lower case to title case

a70fc1c

Merge pull request #1 from kapilepatel/kapilepatel-patch-1

3dff1b0

Minor change-lower case to title case

goldbergyoni self-assigned this Dec 27, 2018

goldbergyoni requested review from BrunoScheufler, js-kyle and sagirk December 27, 2018 15:00

Merge pull request goldbergyoni#309 from kapilepatel/master

d848750

Minor text change- lower case to title case

BrunoScheufler reviewed Dec 27, 2018

View reviewed changes

README.md Outdated Show resolved Hide resolved

BrunoScheufler reviewed Dec 27, 2018

View reviewed changes

sections/performance/nativeoverutil.md Outdated Show resolved Hide resolved

sections/performance/nativeoverutil.md Outdated Show resolved Hide resolved

rhapsodyn and others added 4 commits December 29, 2018 10:57

Update README.chinese.md

7aa2eef

+Removing original eng text +Fix wired Expression

Update README.md

f06a34c

Co-Authored-By: Berkmann18 <maxieberkmann@gmail.com>

Update sections/performance/nativeoverutil.md

1cf1ff8

Co-Authored-By: Berkmann18 <maxieberkmann@gmail.com>

Updated sections/performance/nativeoverutil.md

98a6ae1

BrunoScheufler previously approved these changes Dec 29, 2018

View reviewed changes

goldbergyoni self-requested a review January 1, 2019 08:09

goldbergyoni requested changes Jan 1, 2019

View reviewed changes

justjavac and others added 4 commits January 1, 2019 21:03

fix npm link

cd5c872

Merge pull request goldbergyoni#312 from justjavac/patch-1

0f9ee3e

fix npm link

chores: december maintenance

a01d4df

Updated README and a section

ecb875c

Berkmann18 dismissed BrunoScheufler’s stale review via ecb875c January 1, 2019 13:55

Merge pull request goldbergyoni#310 from rhapsodyn/patch-1

1fd7991

Update README.chinese.md

goldbergyoni reviewed Jan 3, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

Updated README and nativeoverutil

78c626f

Improved the examples and swapped some text with images.

goldbergyoni reviewed Jan 9, 2019

View reviewed changes

BrunoScheufler and others added 3 commits January 9, 2019 08:48

Merge pull request goldbergyoni#313 from i0natan/chores/december

bb9810f

December 2018 maintenance

Merge branch 'dev' of https://github.com/Berkmann18/nodebestpractices …

5b9900e

…into dev

Revisited nativeoverutil.md

1c9c4d6

goldbergyoni approved these changes Jan 14, 2019

View reviewed changes

goldbergyoni merged commit 3933767 into goldbergyoni:master Jan 14, 2019

elite0226 pushed a commit to elite0226/nodebestpractices that referenced this pull request Oct 31, 2022

Merge pull request goldbergyoni#305 from Berkmann18/dev

aa700a4

Added 'Native methods Over Util' article

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added 'Native methods Over Util' article #305

Added 'Native methods Over Util' article #305

Berkmann18 commented Dec 25, 2018

goldbergyoni commented Dec 27, 2018

BrunoScheufler left a comment

Berkmann18 commented Dec 29, 2018

BrunoScheufler left a comment

BrunoScheufler commented Dec 29, 2018

Berkmann18 commented Dec 30, 2018

goldbergyoni left a comment

goldbergyoni Jan 1, 2019

Berkmann18 Jan 1, 2019 •

edited

Loading

goldbergyoni Jan 3, 2019

Berkmann18 Jan 4, 2019

goldbergyoni Jan 1, 2019 •

edited

Loading

Berkmann18 Jan 1, 2019 •

edited

Loading

goldbergyoni Jan 1, 2019 •

edited

Loading

goldbergyoni Jan 3, 2019

Berkmann18 Jan 4, 2019 •

edited

Loading

goldbergyoni left a comment

goldbergyoni Jan 9, 2019

Berkmann18 Jan 9, 2019

goldbergyoni Jan 9, 2019

Berkmann18 Jan 9, 2019

goldbergyoni commented Jan 14, 2019

Berkmann18 commented Jan 14, 2019


		TL;DR: It's often more penalising to use utility libraries like `lodash` and `underscore` over native methods as it leads to unneeded dependencies and slower performance.

		Otherwise: You'll have to maintain (slightly) bigger projects where you could have simply used what was already available or dealt with a few more lines in exchange of a few more files.


		### One Paragraph Explainer

		Sometimes, using native methods is better than requiring `lodash` or `underscore` because the resulting program will have more dependencies and thus use more space and also not guarantee the best performance all-round.


		<br/><br/>

		### Code Example – Benchmark test on `_.concat`/`Array.concat`


		> Lodash and Underscore are great modern JavaScript utility libraries, and they are widely used by Front-end developers. However, when you are targeting modern browsers, you may find out that there are many methods which are already supported natively thanks to ECMAScript5 [ES5] and ECMAScript2015 [ES6]. If you want your project to require fewer dependencies, and you know your target browser clearly, then you may not need Lodash/Underscore.

		There's also an [ESLint plugin](https://www.npmjs.com/package/eslint-plugin-you-dont-need-lodash-underscore) which detects where you're using libraries but don't need to.

Added 'Native methods Over Util' article #305

Added 'Native methods Over Util' article #305

Conversation

Berkmann18 commented Dec 25, 2018

goldbergyoni commented Dec 27, 2018

BrunoScheufler left a comment

Choose a reason for hiding this comment

Berkmann18 commented Dec 29, 2018

BrunoScheufler left a comment

Choose a reason for hiding this comment

BrunoScheufler commented Dec 29, 2018

Berkmann18 commented Dec 30, 2018

goldbergyoni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Berkmann18 Jan 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goldbergyoni Jan 1, 2019 • edited Loading

Choose a reason for hiding this comment

Berkmann18 Jan 1, 2019 • edited Loading

Choose a reason for hiding this comment

goldbergyoni Jan 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Berkmann18 Jan 4, 2019 • edited Loading

Choose a reason for hiding this comment

goldbergyoni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goldbergyoni commented Jan 14, 2019

Berkmann18 commented Jan 14, 2019

Berkmann18 Jan 1, 2019 •

edited

Loading

goldbergyoni Jan 1, 2019 •

edited

Loading

Berkmann18 Jan 1, 2019 •

edited

Loading

goldbergyoni Jan 1, 2019 •

edited

Loading

Berkmann18 Jan 4, 2019 •

edited

Loading