Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid panic with plugin without description #5312

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 10, 2025

panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/golangci/golangci-lint/pkg/commands.formatDescription({0x0, 0x0})
        /tmp/custom-gcl2430187412/golangci-lint/pkg/commands/help.go:222 +0x125
github.com/golangci/golangci-lint/pkg/commands.printLinters({0xc0006251c0, 0x7, 0xc0006ad428?})
        /tmp/custom-gcl2430187412/golangci-lint/pkg/commands/help.go:187 +0x1d9
github.com/golangci/golangci-lint/pkg/commands.(*lintersCommand).execute(0xc000926f50, 0xc000743a90?, {0x0?, 0x0?, 0x0?})
        /tmp/custom-gcl2430187412/golangci-lint/pkg/commands/linters.go:102 +0x285
github.com/spf13/cobra.(*Command).execute(0xc000910308, {0x2a45c40, 0x0, 0x0})
        /home/ldez/sources/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:985 +0xaaa
github.com/spf13/cobra.(*Command).ExecuteC(0xc000910008)
        /home/ldez/sources/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1117 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
        /home/ldez/sources/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1041
github.com/golangci/golangci-lint/pkg/commands.(*rootCommand).Execute(0xc00090c750)
        /tmp/custom-gcl2430187412/golangci-lint/pkg/commands/root.go:83 +0x3d
github.com/golangci/golangci-lint/pkg/commands.Execute({{0x1e16388, 0x8}, {0x1e1e5f0, 0x12}, {0x1e0d768, 0x1}, {0x1e2c040, 0x27}})
        /tmp/custom-gcl2430187412/golangci-lint/pkg/commands/root.go:17 +0x5a
main.main()
        /tmp/custom-gcl2430187412/golangci-lint/cmd/golangci-lint/main.go:25 +0xc5

@ldez ldez added bug Something isn't working linter: custom About custom/private linters labels Jan 10, 2025
@ldez ldez added this to the next milestone Jan 10, 2025
@ldez ldez merged commit ace35f0 into golangci:master Jan 11, 2025
15 checks passed
@ldez ldez deleted the fix/empty-description branch January 11, 2025 12:34
@ldez ldez modified the milestones: next, v1.64 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linter: custom About custom/private linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants