Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

govet: fix stdversion #5168

Merged
merged 3 commits into from
Nov 28, 2024
Merged

govet: fix stdversion #5168

merged 3 commits into from
Nov 28, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 28, 2024

Adds missing elements from #5160.

Before this PR, stdversion was not working.

@ldez ldez added bug Something isn't working linter: update Update the linter implementation inside golangci-lint labels Nov 28, 2024
@ldez ldez added this to the next milestone Nov 28, 2024
@ldez ldez requested a review from bombsimon November 28, 2024 01:48
@ldez ldez requested a review from alexandear November 28, 2024 18:58
@ldez ldez merged commit 6b000ab into golangci:master Nov 28, 2024
15 checks passed
@ldez ldez deleted the fix/stdversion branch November 28, 2024 19:23
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandear alexandear alexandear approved these changes

@bombsimon bombsimon Awaiting requested review from bombsimon

Assignees
No one assigned
Labels
bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.63
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @alexandear