Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused: support passing in options #4086

Merged
merged 3 commits into from
Oct 9, 2023
Merged

unused: support passing in options #4086

merged 3 commits into from
Oct 9, 2023

Conversation

fatanugraha
Copy link
Contributor

@fatanugraha fatanugraha commented Sep 15, 2023

Allow users to tune unused's behavior.

To avoid mutating global parameters, this PR avoids re-using the exported analysis.Analyzer and implement it in the same fashion as staticcheck's internal/cmd/unused

Fixes #4085

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2023

CLA assistant check
All committers have signed the CLA.

@fatanugraha fatanugraha changed the title #4085 Support passing in unused options unused: support passing in options Sep 15, 2023
@ldez ldez self-requested a review September 15, 2023 17:52
@ldez ldez added enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint labels Sep 15, 2023
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit bce3dfd into golangci:master Oct 9, 2023
11 checks passed
@ldez ldez modified the milestone: v1.55 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unused: support options
3 participants