Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wastedassign: remove limitation related to generics support #3689

Merged
merged 1 commit into from
Mar 13, 2023
Merged

wastedassign: remove limitation related to generics support #3689

merged 1 commit into from
Mar 13, 2023

Conversation

Antonboom
Copy link
Contributor

@Antonboom Antonboom commented Mar 13, 2023 •
edited
Loading

@Antonboom Antonboom requested a review from ldez March 13, 2023 17:59
@ldez ldez added the blocked Need's direct action from maintainer label Mar 13, 2023
@ldez ldez changed the title Enable wastedassign Re-enable wastedassign Mar 13, 2023
@ldez ldez changed the title Re-enable wastedassign wastedassign: remove limitation related to generics support Mar 13, 2023
@ldez ldez added linter: update Update the linter implementation inside golangci-lint enhancement New feature or improvement and removed blocked Need's direct action from maintainer labels Mar 13, 2023
ldez
ldez approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run my tests suite (not the golangci-lint tests) that contains multiple and complex generics usages and everything seems to work.

@ldez ldez merged commit ff50ae4 into golangci:master Mar 13, 2023
mihaitodor added a commit to mihaitodor/connect that referenced this pull request Mar 18, 2023
@mihaitodor
Disable gocritic and re-enable wastedassign
72712bc 
- gogritic is very slow (golangci-lint v1.52.0)
- wastedassign received support for generics: golangci/golangci-lint#3689
@mihaitodor mihaitodor mentioned this pull request Mar 18, 2023
Merged
mihaitodor added a commit to mihaitodor/connect that referenced this pull request Mar 19, 2023
@mihaitodor
Disable gocritic and re-enable wastedassign
f7902e9 
- gogritic is very slow (golangci-lint v1.52.0)
- wastedassign received support for generics: golangci/golangci-lint#3689
- Refactor httpclient.Client.ResponseToBatch to fix wastedassign
warning
mihaitodor added a commit to mihaitodor/connect that referenced this pull request Mar 19, 2023
@mihaitodor
Disable gocritic and re-enable wastedassign
310bf15 
- gogritic is very slow (golangci-lint v1.52.0)
- wastedassign received support for generics: golangci/golangci-lint#3689
- Refactor httpclient.Client.ResponseToBatch to fix wastedassign
warning
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@Antonboom @SeigeC
wastedassign: remove limitation related to generics support (golangci…
4764f8d 
…#3689)
@silverwind silverwind mentioned this pull request Apr 21, 2023
Merged
silverwind added a commit to go-gitea/gitea that referenced this pull request Apr 22, 2023
@silverwind
Update go tool dependencies, restructure lint targets (#24239)
8dc6eab 
- Update all tool dependencies to latest tag
- Remove unused errcheck, it is part of golangci-lint
- Include main.go in air
- Enable wastedassign again now that it's
[generics-compatible](golangci/golangci-lint#3689)
- Restructured lint targets to new `lint-*` namespace
@lvrach lvrach mentioned this pull request Jun 5, 2023
Merged
1 task
@ldez ldez added this to the v1.52 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.52
Development

Successfully merging this pull request may close these issues.

SSA and generics (go1.18)
2 participants
@Antonboom @ldez