fix incompatible call for gofumpt #1235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple days ago, there is incompatible change method declaration for format.Source() Check this commit for the change mvdan/gofumpt@42bb513 Simply run `go get -u github.com/golangci/golangci-lint/cmd/golangci-lint` will fail `golangci-lint@v1.28.3/pkg/golinters/gofumpt.go:49:41: cannot use "" (type string) as type format.Options in argument to format.Source`
|
Hey, thank you for opening your first Pull Request ! |
|
|
sayboras
reviewed
Jul 12, 2020
sayboras
requested changes
Jul 12, 2020
|
This bug is already fixed in #1228 |
Closed
This was referenced Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple days ago, there is incompatible change method declaration for format.Source()
Check this commit for the change
mvdan/gofumpt@42bb513
Simply run
go get -u github.com/golangci/golangci-lint/cmd/golangci-lintwill failgolangci-lint@v1.28.3/pkg/golinters/gofumpt.go:49:41: cannot use "" (type string) as type format.Options in argument to format.Source