Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocyclo repository seems to be abandoned #753

Closed
trajber opened this issue Sep 26, 2019 · 5 comments
Closed

gocyclo repository seems to be abandoned #753

trajber opened this issue Sep 26, 2019 · 5 comments
Labels
dependencies Relates to an upstream dependency enhancement New feature or improvement question Further information is requested stale No recent correspondence or work activity

Comments

@trajber
Copy link

trajber commented Sep 26, 2019

The gocyclo upstream seems to abandoned a long time ago. There are open issues and PRs that never get any feedback.
What do you think about create a maintained fork of it ?
@tpounds
Copy link
Contributor

tpounds commented Sep 29, 2019

@trajber There is already a project fork at https://github.com/golangci/gocyclo. Are you asking to have those prs merged in there?

@tpounds tpounds added question Further information is requested enhancement New feature or improvement dependencies Relates to an upstream dependency labels Sep 29, 2019
@OrBaruk
Copy link

OrBaruk commented Oct 7, 2019

Hi, I work with @trajber and the what we are interested in getting merged is the PR fzipp/gocyclo#27 for the issue fzipp/gocyclo#19

We weren't aware of the the fork used by golangci-lint if there is interest I can open this PR on https://github.com/golangci/gocyclo

@tpounds
Copy link
Contributor

tpounds commented Oct 7, 2019

@trajber, @OrBaruk That would be fantastic! The first preference is always to upstream changes as much as possible but when that isn't possible the changes can be forked by the project or included directly which is the case for some linters like dogsled, lll, nakedret, etc. If you take a look at the go.mod file you can see which linters have been forked to include additions.

@OrBaruk
Copy link

OrBaruk commented Oct 8, 2019

@tpounds Created golangci/gocyclo#3

@stale
Copy link

stale bot commented Apr 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent correspondence or work activity label Apr 5, 2020
@stale stale bot closed this as completed Apr 19, 2020
theckman pushed a commit to theckman/golangci-lint that referenced this issue May 3, 2020
@jirfag
update go-critic
b31cfd6 
$ git cherry --abbrev -v 0af0999fabfb ee9bf5809ead
+ abd8436 all: enable Go modules on CI (golangci#753)
+ 3c9d0fb checkers: recognize //line and //nolint in commentFormatting (golangci#756)
+ 0b517d7 checkers: extend deprecatedComment patterns (golangci#757)
+ 09100f6 checkers: use astcast package instead of coerce.go (golangci#758)
+ 2e9e97f checker: simplify boolExprSimplify (golangci#759)
+ 575701e make: add go-consistent to CI checks list (golangci#761)
+ b55f431 checkers: fix unlambda handling of builtins (golangci#763)
+ 5a7dee3 checker: handle lambdas properly in boolExprSimplify (golangci#765)
+ 5ce3939 checkers: teach boolExprSimplify a few new tricks (golangci#766)
+ 04d160f checkers: add new patterns to boolExprSimplify (golangci#768)
+ 09582e2 make: collect coverprofile separately from goveralls (golangci#769)
+ d8d0ee4 checkers: recognize NOTE pattern in deprecatedComment (golangci#770)
+ 12f0f85 Update copyright notice to 2019 (golangci#771)
+ f54bdb6 checkers: add stringXbytes checker
+ 170d65c checkers: followup for golangci#773 (golangci#774)
+ 84e9e83 checkers: make stringXbytes more linear (golangci#775)
+ a800815 checkers: add Depreacted typo pattern (golangci#776)
+ 6751be9 checkers: add hexLiterals (golangci#772)
+ ac61906 checkers: add typeAssertChain checker (golangci#782)
+ d19dbf1 checkers: add codegenComment checker (golangci#783)
+ d82b576 checkers: proper pkg/obj check for flagName (golangci#786)
+ dfcf754 ci: enable integration tests (golangci#787)
+ 5dafc45 checkers: fix equalFold false positive (golangci#788)
+ ed5e8e7 checkers: refactor and fix hexLiteral checker (golangci#789)
+ e704e07 checkers: add argOrder checker (golangci#790)
+ 34c1dc8 checkers: add Split handling to argOrder checker (golangci#791)
+ cbe095d checkers: add math.Max and math.Min to dupArg (golangci#792)
+ c986ee5 checkers: add checkers info fields test (golangci#794)
+ 66e5832 cmd/makedocs: use lintpack, fix build (golangci#793)
+ 6bce9d0 cmd/makedocs: add enabled/disabled by default info (golangci#795)
+ 4adbf9a checkers: simplify flagName (golangci#799)
+ 07de34a checkers: add octalLiteral checker (golangci#798)
+ 765907a cmd/makedocs: add checker param docs (golangci#796)
+ ee9bf58 cmd/makedocs: fix headers formatting (golangci#803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Relates to an upstream dependency enhancement New feature or improvement question Further information is requested stale No recent correspondence or work activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tpounds @trajber @OrBaruk