Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The defaults for gci sections are inverted #2588

Closed
cardil opened this issue Feb 17, 2022 · 3 comments · Fixed by #2589
Closed

The defaults for gci sections are inverted #2588

cardil opened this issue Feb 17, 2022 · 3 comments · Fixed by #2589
Assignees
@ldez
Labels
bug Something isn't working

Comments

@cardil
Copy link
Contributor

cardil commented Feb 17, 2022

This should be []string{"standard", "default"}.

Originally posted by @cardil in #2532 (comment)
@cardil
Copy link
Contributor Author

cardil commented Feb 17, 2022

The #2532 caused a regression in golangci-lint, by changing effective defaults.

@ldez ldez self-assigned this Feb 17, 2022
@ldez
Copy link
Member

ldez commented Feb 17, 2022

Hello, Thank you I will fix that

@cardil cardil mentioned this issue Feb 17, 2022
Merged
@cardil
Copy link
Contributor Author

cardil commented Feb 17, 2022

I've just opened #2589

@ldez ldez added the bug Something isn't working label Feb 17, 2022
cardil added a commit to wavesoftware/go-magetasks that referenced this issue Feb 17, 2022
@cardil
Configure gci sections to fix golangci/golangci-lint#2588
d95ed39
cardil added a commit to wavesoftware/go-magetasks that referenced this issue Feb 17, 2022
@cardil
🧹 Upgrade deps (#30)
c443dfb 
* Upgrade deps

* Upgrade deps p.2

* Upgrade p.3

* Fixing lint errors

* Testing with gotestsum and contenerizing build tools

* Configure gci sections to fix golangci/golangci-lint#2588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldez ldez

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gci: restore defaults for sections cardil/golangci-lint
2 participants
@cardil @ldez