Skip to content

Commit

Permalink
go1.11 compatibility fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
jirfag committed Mar 5, 2019
1 parent be0679e commit a5c44d2
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions test/linters_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import (
"strings"
"testing"

"github.com/golangci/golangci-lint/pkg/exitcodes"

"github.com/golangci/golangci-lint/test/testshared"

assert "github.com/stretchr/testify/require"
Expand All @@ -20,9 +18,12 @@ import (

func runGoErrchk(c *exec.Cmd, files []string, t *testing.T) {
output, err := c.CombinedOutput()
exitErr, ok := err.(*exec.ExitError)
assert.Error(t, err)
_, ok := err.(*exec.ExitError)
assert.True(t, ok)
assert.Equal(t, exitcodes.IssuesFound, exitErr.ExitCode())

// TODO: uncomment after deprecating go1.11
// assert.Equal(t, exitcodes.IssuesFound, exitErr.ExitCode())

fullshort := make([]string, 0, len(files)*2)
for _, f := range files {
Expand Down

0 comments on commit a5c44d2

Please sign in to comment.