VSCode crash by Go

[NhokCrazy199]

Issue Type: Bug

c:\Users\PhamK.vscode\extensions\golang.go-0.16.0\dist\goMain.js:26315
throw err;
^

SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at c:\Users\PhamK.vscode\extensions\766b.go-outliner-0.1.20\out\app.js:187:45
at ChildProcess.exithandler (child_process.js:315:5)
at ChildProcess.emit (events.js:203:13)
at ChildProcess.EventEmitter.emit (domain.js:476:20)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)

Extension version: 0.16.0
VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:12:49.994Z)
OS version: Windows_NT x64 10.0.19041

[hyangah]

@NhokCrazy199 Thanks for the bug report.

It looks like the original exception was from the go-outliner extension (766b.go-outliner).

But the exception from other extension started to affect our extension since Go 0.16.0 release.
I think this is a side-effect of the inlined debug adapter. cc @eliben

The code that threw an error is originated from goDlvDebug.ts:

process.on('uncaughtException', (err) => {
    const errMessage = err && (err.stack || err.message);
    vscode_debugadapter_1.logger.error(`Unhandled error in debug adapter: ${errMessage}`);
    throw err;
});

This is installing a process-wide uncaught exception handler.

It was packed in goMain.js probably because it's using the inlined debug adapter factory.

The dlv dap debug adapter is still in early stages, so I think it's better not to inline.
And when inlining, we should be aware of this process-wide exception handler.

[ivanovishado]

Hi, @hyangah. Is there any solution? Any way I can help? Is more info needed? Let me know since this same error is happening to me.

I guess this information could be relevant:

- Run `go version` to get version of Go
	- go version go1.12.9 darwin/amd64
- Run `code -v` or `code-insiders -v` to get version of VS Code or VS Code Insiders
	- 1.47.3 91899dcef7b8110878ea59626991a18c8a6a1b3e x64
- Check your installed extensions to get the version of the VS Code Go extension 
	- 0.16.0
- Run `go env` to get the go development environment details
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/ivan.galaviz/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/ivan.galaviz/.gvm/pkgsets/go1.12.9/global"
GOPROXY=""
GORACE=""
GOROOT="/Users/ivan.galaviz/.gvm/gos/go1.12.9"
GOTMPDIR=""
GOTOOLDIR="/Users/ivan.galaviz/.gvm/gos/go1.12.9/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/_c/twwltvld2bjgl0k08lt6dq4h0000gn/T/go-build576750648=/tmp/go-build -gno-record-gcc-switches -fno-common"

[gopherbot]

Change https://golang.org/cl/246777 mentions this issue: src/debugAdapter2: launch as an external process, and fix config

[hyangah]

@ivanovishado thanks! In the mean time, roll back to 0.15.2. Extensions view -> Select "Go" extension -> Click the gear icon -> Install Another Version... -> Choose 0.15.2.

[ivanovishado]

Thanks, @hyangah!

[hyangah]

This is not yet released. Since this is a major bug, I will keep this open until it's released and verified.

[gopherbot]

Change https://golang.org/cl/246959 mentions this issue: [release] src/debugAdapter2: launch as an external process, and fix config

[hyangah]

RC.1 is out. https://github.com/golang/vscode-go/releases/tag/v0.16.1-rc.1

@NhokCrazy199 @ivanovishado @zhanswift Can you check if the RC1 addresses this issue?
There is a link to the installation instruction. Many many thanks! 🙏

[ivanovishado]

@hyangah, I installed it and restarted Code several times. No issues so far. 👍

[hyangah]

Thanks all for verifying the fix. 0.16.1 is released.