Skip to content

Commit

Permalink
.github/workflows, build: install dlv in containers
Browse files Browse the repository at this point in the history
Tests now require dlv

Change-Id: I3e144cb08938c98f661b480772bd62bdc971ea24
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/251084
Reviewed-by: Robert Findley <rfindley@google.com>
  • Loading branch information
hyangah committed Aug 27, 2020
1 parent c169d13 commit cd41bd1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/release-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ jobs:
go get github.com/cweill/gotests/...
go get github.com/rogpeppe/godef
go get github.com/ramya-rao-a/go-outline
go get github.com/go-delve/delve/cmd/dlv
env:
GO111MODULE: on

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-long.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
go get github.com/cweill/gotests/...
go get github.com/rogpeppe/godef
go get github.com/ramya-rao-a/go-outline
go get github.com/go-delve/delve/cmd/dlv
env:
GO111MODULE: on

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
go get github.com/cweill/gotests/...
go get github.com/rogpeppe/godef
go get github.com/ramya-rao-a/go-outline
go get github.com/go-delve/delve/cmd/dlv
env:
GO111MODULE: on

Expand Down
3 changes: 2 additions & 1 deletion build/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ RUN GO111MODULE=on go get -x -v github.com/acroca/go-symbols && \
GO111MODULE=on go get -x -v github.com/uudashr/gopkgs/v2/cmd/gopkgs && \
GO111MODULE=on go get -x -v github.com/zmb3/gogetdoc && \
GO111MODULE=on go get -x -v golang.org/x/lint/golint && \
GO111MODULE=on go get -x -v golang.org/x/tools/cmd/gorename
GO111MODULE=on go get -x -v golang.org/x/tools/cmd/gorename && \
GO111MODULE=on go get -x -v github.com/go-delve/delve/cmd/dlv

WORKDIR /workspace
ENTRYPOINT ["build/all.bash"]

0 comments on commit cd41bd1

Please sign in to comment.