-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txtar: add fs.FS support #289
Conversation
This PR (HEAD: 6cf2566) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 1: (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/301712. |
Message from Carl Johnson: Patch Set 2: (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/301712. |
This PR (HEAD: cf0e23f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it. Tip: You can toggle comments from me using the |
Message from Josh Bleecher Snyder: Patch Set 3: (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/301712. |
Message from Carl Johnson: Patch Set 3: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/301712. |
This PR (HEAD: 1cfb807) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it. Tip: You can toggle comments from me using the |
Message from Carl Johnson: Patch Set 4: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/301712. |
This PR (HEAD: 2147765) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it. Tip: You can toggle comments from me using the |
Message from Carl Johnson: Patch Set 5: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/301712. |
Message from Carl Johnson: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/301712. |
This PR (HEAD: e13b525) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it. Tip: You can toggle comments from me using the |
/comments off |
e13b525
to
746770f
Compare
@gopherbot /comments on |
Fixes golang/go#44158 From implementation copied with permission from https://github.com/josharian/txtarfs/blob/main/txtarfs_test.go golang/go#44158 (comment)
9d1c409
to
3e6aa58
Compare
From implementation copied with permission from @josharian
https://github.com/josharian/txtarfs/blob/main/txtarfs_test.go
golang/go#44158 (comment)
Fixes #44158