Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txtar: add fs.FS support #289

Closed
wants to merge 17 commits into from
Closed

Conversation

earthboundkid
Copy link
Contributor

@earthboundkid earthboundkid commented Mar 15, 2021

From implementation copied with permission from @josharian
https://github.com/josharian/txtarfs/blob/main/txtarfs_test.go
golang/go#44158 (comment)

Fixes #44158

@google-cla google-cla bot added the cla: yes label Mar 15, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 6cf2566) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(7 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301712.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 2:

(7 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301712.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: cf0e23f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Josh Bleecher Snyder:

Patch Set 3:

(9 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301712.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 3:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301712.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 1cfb807) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 4:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301712.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 2147765) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 5:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301712.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/301712.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e13b525) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/301712 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@earthboundkid
Copy link
Contributor Author

/comments off

@earthboundkid
Copy link
Contributor Author

@gopherbot /comments on

@earthboundkid earthboundkid deleted the add-fs3 branch July 18, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants