Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Add AtLeastOnce() method #22

Closed
wants to merge 1 commit into from
Closed

Add AtLeastOnce() method #22

wants to merge 1 commit into from

Conversation

duskhacker
Copy link

Allows a test to ensure that a call happens at least
one time, but doesn't care how many more times a call occurs.

I've added this because in some event-driven testing that I'm doing
I cannot always know how many times the event will happen, so
Times() is not appropriate, but I need to ensure it gets called,
so AnyTimes() is also not appropriate.

Allows a test to ensure that an call happens at least
one time, but doesn't care how many more times a call occurs.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@duskhacker
Copy link
Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@duskhacker
Copy link
Author

I signed it!

1 similar comment
@duskhacker
Copy link
Author

I signed it!

@dsymonds
Copy link
Contributor

This might be better named as MinTimes, and have it only set the minimum. Then there can be a MaxTimes to mirror it.

@dsymonds
Copy link
Contributor

The CLA checker is getting confused. Rackspace has signed a corp CLA, so you're fine on that front.

@duskhacker
Copy link
Author

Closing to get this CLA business sorted out.

@duskhacker duskhacker closed this Jan 20, 2016
@duskhacker duskhacker reopened this Jan 20, 2016
@duskhacker
Copy link
Author

@dsymonds RE CLA: I closed it before I noticed your comment about it. So, I'm confused, can I just ignore that CLA business, or what do I have to do something to make the CLA checker happy?

RE Mintimes/Maxtimes: I'll change it in another branch.

@dsymonds
Copy link
Contributor

Yes, ignore the googlebot complaining about the CLA. I thought it was meant to cope with corporate CLAs, but it clearly isn't in this case. Your contribution is covered by Rackspace's CLA.

@duskhacker
Copy link
Author

@dsymonds Thank you for your prompt response! I'll close this and open another one with the changes you suggested.

@duskhacker duskhacker closed this Jan 20, 2016
@dsymonds
Copy link
Contributor

Okay, or you can just amend the commit on this PR. Up to you.

@duskhacker duskhacker deleted the add-at-least-once branch January 21, 2016 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants