-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/doc: added the predeclared identifiers clear, min, max #68029
Conversation
This PR (HEAD: 0fc6472) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/593015. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Mauri de Souza Meneguzzo: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Briheet Singh Yadav: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Briheet Singh Yadav: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: Code-Review+1 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-17T13:59:29Z","revision":"5680b7abfe0e7be8a8affefb4da57d45178ac51e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
This PR (HEAD: 2325b0e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/593015. Important tips:
|
Message from Briheet Singh Yadav: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Briheet Singh Yadav: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Robert Griesemer: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
This PR (HEAD: 8dd3467) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/593015. Important tips:
|
Message from Briheet Singh Yadav: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Robert Griesemer: Patch Set 5: Code-Review+1 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-17T16:17:12Z","revision":"a951dfbd47aaaa932cd6d6c052100f1a007c181d"} Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Briheet Singh Yadav: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result-1 Copied votes on follow-up patch sets have been updated:
Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-17T16:30:19Z","revision":"51e80019448114ca82596e48c6d8f43395786a9b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Robert Griesemer: Patch Set 6: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-17T16:38:40Z","revision":"51e80019448114ca82596e48c6d8f43395786a9b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Robert Griesemer: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Robert Griesemer: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/593015. |
Fixes: #68028 Change-Id: Ib341b9f57b001cccc5dc9e822b7feaabcdb77e63 GitHub-Last-Rev: 8dd3467 GitHub-Pull-Request: #68029 Reviewed-on: https://go-review.googlesource.com/c/go/+/593015 Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Robert Griesemer <gri@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> Reviewed-by: Robert Griesemer <gri@google.com>
This PR is being closed because golang.org/cl/593015 has been merged. |
Fixes: #68028 Change-Id: Ib341b9f57b001cccc5dc9e822b7feaabcdb77e63 GitHub-Last-Rev: 8dd3467016088ab2a8797f14065d2e6104eb0505 GitHub-Pull-Request: golang/go#68029 Reviewed-on: https://go-review.googlesource.com/c/go/+/593015 Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Robert Griesemer <gri@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> Reviewed-by: Robert Griesemer <gri@google.com>
Fixes: #68028