Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/csv: allow for interpretation of empty lines #45228

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kdumontnu
Copy link

Thanks to @kokes for the initial effort on this PR

Empty lines are ignored by default, this change introduces a switch that
changes this behaviour - empty line is then interpreted as a single empty
field. This is especially important when dealing with single-column CSVs,
where an empty line is actually data (an empty field).

Fixes #39119 and supersedes stalled PR #39556

kokes and others added 2 commits March 25, 2021 00:44
Empty lines are ignored by default, this change introduces a switch that
changes this behaviour - empty line is then interpreted as a single empty
field.
@google-cla
Copy link

google-cla bot commented Mar 25, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Mar 25, 2021
@kdumontnu
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Mar 25, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Nov 10, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 3c15a37) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/363001 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/363001.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Code-Review-2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/363001.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Daniel Martí:

Patch Set 1: Code-Review-2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/363001.
After addressing review feedback, remember to publish your drafts!

@shasaur
Copy link

shasaur commented Feb 28, 2022

Any updates on this? PR is fairly straight-forward but has been open for almost a year.

@mengzhuo
Copy link
Contributor

There is a -2 during review, please visit https://go-review.googlesource.com/c/go/+/363001#message-4d1a47dfc5dd28a78ccbf7bffa8843f975b1e011 for more information

@shasaur
Copy link

shasaur commented Feb 28, 2022

There is a -2 during review, please visit https://go-review.googlesource.com/c/go/+/363001#message-4d1a47dfc5dd28a78ccbf7bffa8843f975b1e011 for more information

That was 2 months ago though. If I understand correctly, the PR will not be accepted until there is a proposal put through first by the person who submitted the PR?

@kokes
Copy link

kokes commented Feb 28, 2022

The original issue did not include a proposal, because at the very beginning we didn't have a potential solution at hand. During the discussion I came up with a potential solution, which could be made into a proposal - #39119 (comment) - I recently thought about proposing this in a structured way, if there's interest.

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 1: Hold+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/363001.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encoding/csv: skipping of empty rows leads to loss of data in single-column datasets
5 participants