Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/go1.16: mention new vet check for asn1.Unmarshal #44147

Closed
wants to merge 2 commits into from
Closed

doc/go1.16: mention new vet check for asn1.Unmarshal #44147

wants to merge 2 commits into from

Conversation

KimMachineGun
Copy link
Contributor

@KimMachineGun KimMachineGun commented Feb 7, 2021 •
edited by dmitshur
Loading

This vet check was added in CL 243397.

For #40700.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 7, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 070c0b6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/290330 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/290330.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e47c38f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/290330 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Geon Kim:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/290330.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/290330.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/290330.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 8, 2021
@KimMachineGun @dmitshur
doc/go1.16: mention new vet check for asn1.Unmarshal
dc725bf 
This vet check was added in CL 243397.

For #40700.

Change-Id: Ibff6df9395d37bb2b84a791443578009f23af4fb
GitHub-Last-Rev: e47c38f
GitHub-Pull-Request: #44147
Reviewed-on: https://go-review.googlesource.com/c/go/+/290330
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/290330 has been merged.

@gopherbot gopherbot closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KimMachineGun @gopherbot