Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #29010, proposal: encoding/binary: add WriteVarint WriteUVa… #29043

Closed
wants to merge 2 commits into from

Conversation

robaho
Copy link

@robaho robaho commented Nov 30, 2018

encoding/binary: add WriteVarint WriteUVarint methods, fixes #29010

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 30, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: 2e59b94) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/152057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/152057.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

Temporary -2 until the proposal is reviewed and accepted.

Also, please see https://golang.org/wiki/CommitMessage .


Please don’t reply on this GitHub thread. Visit golang.org/cl/152057.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Code-Review-2


Please don’t reply on this GitHub thread. Visit golang.org/cl/152057.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 0510666) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/152057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/152057 has been abandoned.

the proposal was rejected.

@gopherbot gopherbot closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: encoding/binary: add WriteVarint WriteUVarint methods
3 participants