-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Closed
Labels
AutomationIssues created by gopherbot or watchflakes automation.Issues created by gopherbot or watchflakes automation.NeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.
Milestone
Description
Regenerating the golang.org/x/tools/internal/stdlib package with Go 1.25.0 (as done in CL 695417) causes one of the test cases, specifically the "a_test.go" file in the TestFuzzFunc
test to fail with:
=== RUN TestFuzzFunc/default
completion18_test.go:119: pat="f.Ad" <<completion item mismatch (-want +got):
[]string{
"Add",
- "Attr",
}
>>
completion18_test.go:121: 0 got "Add" "func(args ...any)"
[...]
(Complete log: https://ci.chromium.org/ui/p/golang/builders/try/x_tools-go1.25-darwin-amd64_14/b8706706619471507793/overview.)
The test case is being temporarily skipped, and this issue is open to track restoring it afterwards.
CC @findleyr.
It looks like CL 674595 intended to make the test more accepting of Go 1.25 changes; not sure why it's not working.
IkkiDK
Metadata
Metadata
Assignees
Labels
AutomationIssues created by gopherbot or watchflakes automation.Issues created by gopherbot or watchflakes automation.NeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.