Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID [1.22 backport] #67314

Closed
gopherbot opened this issue May 10, 2024 · 2 comments
Closed

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID [1.22 backport] #67314

gopherbot opened this issue May 10, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22.4

Comments

@gopherbot
Copy link
Contributor

@matloob requested issue #64947 to be considered for backport to the next 1.22 minor release.

@gopherbot please create a backport issue for Go 1.22
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels May 10, 2024
@gopherbot gopherbot mentioned this issue May 10, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 10, 2024
@gopherbot gopherbot added this to the Go1.22.4 milestone May 10, 2024
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 10, 2024
@matloob matloob added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 11, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/584238 mentions this issue: [release-branch.go1.22] cmd/go/testdata/script: add darwin skips for selected buildrepro tests

@gopherbot
Copy link
Contributor Author

Closed by merging 362dced to release-branch.go1.22.

gopherbot pushed a commit that referenced this issue May 13, 2024
@thanm @gopherbot
[release-branch.go1.22] cmd/go/testdata/script: add darwin skips for …
362dced 
…selected buildrepro tests

Skip two build reproducibility tests (build_issue48319 and
build_plugin_reproducible) on Darwin if GO_BUILDER_NAME is set until
issue 64947 can be resolved; on the LUCI darwin longtest builder the
more contemporary version of Xcode is doing things that are unfriendly
to Go's build reproducibility.

For #64947.
Fixes #67314

Change-Id: Iebd433ad6dfeb84b6504ae9355231d897d8ae174
Reviewed-on: https://go-review.googlesource.com/c/go/+/565376
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 53708d8)
Reviewed-on: https://go-review.googlesource.com/c/go/+/584238
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22.4
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @matloob