Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/internal/mlkem768: TestPQCrystalsAccumulated fails on linux/s390x #66804

Closed
dmitshur opened this issue Apr 12, 2024 · 4 comments
Closed

crypto/internal/mlkem768: TestPQCrystalsAccumulated fails on linux/s390x #66804

dmitshur opened this issue Apr 12, 2024 · 4 comments
Labels
arch-s390x Issues solely affecting the s390x architecture. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-Linux
Milestone
Go1.23

Comments

@dmitshur
Copy link
Contributor

CL 550215 added a new package. One of its tests, TestPQCrystalsAccumulated, is failing on the linux/s390x port:

--- FAIL: TestPQCrystalsAccumulated (0.07s)
    mlkem768_test.go:341: got a29fd28288bf8b0ec26692d56eab5cb44c57fdc7e378133b81b83c4c33c6bb07, expected 8d0c478ead6037897a0da6be21e5399545babf5fc6dd10c061c99b7dee2bf0dc
FAIL

(See https://build.golang.org/log/c33fc12dce181e683b2c21e15d9775633d804637.)

This doesn't seem to happen on other Go ports.

CC @golang/s390x.
@dmitshur dmitshur added OS-Linux NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-s390x Issues solely affecting the s390x architecture. labels Apr 12, 2024
@FiloSottile
Copy link
Contributor

There is no use of unsafe or assembly in that package, so it doesn't look right away as something wrong in crypto/internal/mlkem768.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/578715 mentions this issue: sha3: fix Sum results for SHAKE functions on s390x

gopherbot pushed a commit to golang/crypto that referenced this issue Apr 15, 2024
@mundaym
sha3: fix Sum results for SHAKE functions on s390x
5defcc1 
Sum was taking the digest from the state which is correct for SHA-3
functions but not for SHAKE functions.

Updates golang/go#66804

Change-Id: If782464d773262075950e3168128c0d46e4a6530
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/578715
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Michael Munday <mike.munday@lowrisc.org>
@mundaym
Copy link
Member

mundaym commented Apr 15, 2024

I think this issue should now be fixed when golang.org/x/crypto is re-vendored.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 16, 2024
@dmitshur dmitshur added this to the Go1.23 milestone Apr 16, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/579455 mentions this issue: all: update vendored golang.org/x/crypto

drakkan pushed a commit to drakkan/crypto that referenced this issue May 11, 2024
@mundaym @drakkan
sha3: fix Sum results for SHAKE functions on s390x
566101a 
Sum was taking the digest from the state which is correct for SHA-3
functions but not for SHAKE functions.

Updates golang/go#66804

Change-Id: If782464d773262075950e3168128c0d46e4a6530
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/578715
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Michael Munday <mike.munday@lowrisc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-s390x Issues solely affecting the s390x architecture. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-Linux
Projects
None yet
Milestone
Go1.23
Development

No branches or pull requests
4 participants
@FiloSottile @dmitshur @gopherbot @mundaym