Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh: TestSSHCLIAuth fails on Windows #64403

Open
heschi opened this issue Nov 27, 2023 · 2 comments
Open

x/crypto/ssh: TestSSHCLIAuth fails on Windows #64403

heschi opened this issue Nov 27, 2023 · 2 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Nov 27, 2023

Not sure how I didn't notice this until today. See #60981 previously.

Example: http://ci.chromium.org/b/8763261739598890561:

sign_and_send_pubkey: signing using rsa-sha2-512 SHA256:Anr3LjZK8YVpjrxu79myrW9Hrb/wpcMNpVvTq/RcBm8\r\nBad permissions. Try removing permissions for user: UNKNOWN\\\\UNKNOWN (S-1-15-2-2) on file C:/b/s/w/ir/x/t/TestSSHCLIAuth1586735692/001/rsa.

Seems like a bug in the test so for now I'm going to skip.

cc @drakkan @golang/security @FiloSottile @rolandshoemaker
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 27, 2023
@heschi heschi added this to the Unreleased milestone Nov 27, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/545135 mentions this issue: ssh/test: skip TestSSHCLIAuth on Windows

gopherbot pushed a commit to golang/crypto that referenced this issue Nov 27, 2023
@heschi @gopherbot
ssh/test: skip TestSSHCLIAuth on Windows
325b735 
It's failing with a file permissions error:

sign_and_send_pubkey: signing using rsa-sha2-512 SHA256:Anr3LjZK8YVpjrxu79myrW9Hrb/wpcMNpVvTq/RcBm8\r\nBad permissions. Try removing permissions for user: UNKNOWN\\\\UNKNOWN (S-1-15-2-2) on file C:/b/s/w/ir/x/t/TestSSHCLIAuth1586735692/001/rsa.

For golang/go#64403

Change-Id: Iece8eac4a1ac349f9f7a273ac7389315cb96568e
Cq-Include-Trybots: luci.golang.try:x_crypto-gotip-windows-amd64-longtest,x_crypto-go1.21-windows-amd64-longtest,x_crypto-go1.20-windows-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/545135
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@drakkan
Copy link
Member

drakkan commented Nov 28, 2023

uhmm... I cannot reproduce on Windows 10

Schermata del 2023-11-28 12-56-34

This is currently the only Windows VM I have access to.

It appears that 0600 is not enough to make the private key file not accessible by other users on some versions of Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@drakkan @dmitshur @gopherbot @heschi