Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/text: building as a plugin failure on darwin/arm64 [1.20 backport] #58920

Closed
gopherbot opened this issue Mar 7, 2023 · 2 comments
Closed

x/text: building as a plugin failure on darwin/arm64 [1.20 backport] #58920

gopherbot opened this issue Mar 7, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.3

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #58826 to be considered for backport to the next 1.20 minor release.

@gopherbot please backport this to Go 1.20. This can cause code failing to build. Thanks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 7, 2023
@gopherbot gopherbot mentioned this issue Mar 7, 2023
Closed
@gopherbot gopherbot modified the milestones: Unreleased, Go1.20.3 Mar 7, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/474235 mentions this issue: [release-branch.go1.20] Revert "cmd/compile: enable address folding for global symbols of shared library"

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Mar 15, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 15, 2023
gopherbot pushed a commit that referenced this issue Mar 15, 2023
@cherrymui
[release-branch.go1.20] Revert "cmd/compile: enable address folding f…
5c7cc46 
…or global symbols of shared library"

This reverts CL 445535.

Reason for revert: see issue #58826. It doesn't handle large offset well.

Updates #58826.
Fixes #58920.

Change-Id: Ic4a33f4c510c88628ea7e16207a60977a04cf798
Reviewed-on: https://go-review.googlesource.com/c/go/+/474175
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@google.com>
(cherry picked from commit a4cf4fd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/474235
Reviewed-by: Keith Randall <khr@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging 5c7cc46 to release-branch.go1.20.

@golang golang locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.3
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui