x/tools/go/internal/gcimporter: frequent "out of memory" failures on 32-bit builders #45931

bcmills · 2021-05-03T18:36:21Z

It's not clear to me whether these test failures are due to a problem in gcimporter itself, or due to memory pressure from concurrently-running tests for another package, but the failure rate for the x/tools repo on the linux-arm-scaleway builder especially is quite high, and the windows-386-2008 failure rate is at least high enough that I noticed it on a TryBot run (https://storage.googleapis.com/go-build-log/7f9febd4/windows-386-2008_2222fa56.log).

Perhaps gcimporter_test needs a lower concurrency limit on 32-bit platforms?

CC @stamblerre @griesemer

The text was updated successfully, but these errors were encountered:

findleyr · 2021-05-03T19:06:08Z

It's not clear to me whether these test failures are due to a problem in gcimporter itself, or due to memory pressure from concurrently-running tests for another package

It may be the latter, considering that we're not seeing equivalent OOMing in go/internal/gcimporter.

Note that the Scaleway builders are slated for deprecation:
#45066

bcmills · 2021-05-03T19:09:37Z

Note that the Scaleway builders are slated for deprecation:

Yep, but AFAIK the windows-386 builders aren't. 😅

gopherbot · 2021-05-24T23:54:07Z

Change https://golang.org/cl/322409 mentions this issue: internal/testenv: update linux-arm to linux-arm-scaleway

CL 303230 renamed the linux-arm builder to linux-arm-scaleway, but the x/tools ExitIfSmallMachine guard was not updated accordingly, resulting in consistent failures for some tests. For golang/go#45931 For golang/go#46183 Updates golang/go#32834 Change-Id: Ief5f17fc61cb38cf6b7cf63b6cd5e64f9d56261e Reviewed-on: https://go-review.googlesource.com/c/tools/+/322409 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

bcmills · 2021-11-02T20:17:15Z

Looks like this failure mode went away with the linux-arm-scaleway builder. (I don't know why we're not observing faillures on windows-386.)

greplogs --dashboard -md -l -e '(?ms)out of memory.*FAIL\s+golang\.org/x/tools/go/internal/gcimporter' --since=2021-05-04

bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 3, 2021

bcmills added this to the Backlog milestone May 3, 2021

gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label May 3, 2021

bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 3, 2021

This was referenced May 10, 2021

x/tools/go/internal/gcimporter: frequent failures without useful output #38415

Closed

runtime: SIGSEGV in mmap_trampoline on openbsd-386-64 builder #46080

Closed

x/tools/gopls/internal/regtest/*: frequent failures on smaller builders #46183

Open

bcmills closed this as completed Nov 2, 2021

golang locked and limited conversation to collaborators Nov 2, 2022

gopherbot added the FrozenDueToAge label Nov 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/go/internal/gcimporter: frequent "out of memory" failures on 32-bit builders #45931

x/tools/go/internal/gcimporter: frequent "out of memory" failures on 32-bit builders #45931

bcmills commented May 3, 2021

findleyr commented May 3, 2021

bcmills commented May 3, 2021

gopherbot commented May 24, 2021

bcmills commented Nov 2, 2021 •

edited

Loading

x/tools/go/internal/gcimporter: frequent "out of memory" failures on 32-bit builders #45931

x/tools/go/internal/gcimporter: frequent "out of memory" failures on 32-bit builders #45931

Comments

bcmills commented May 3, 2021

findleyr commented May 3, 2021

bcmills commented May 3, 2021

gopherbot commented May 24, 2021

bcmills commented Nov 2, 2021 • edited Loading

bcmills commented Nov 2, 2021 •

edited

Loading