Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: investigate regtest performance on linux-arm builder #43355

Closed
findleyr opened this issue Dec 23, 2020 · 5 comments
Closed

x/tools/gopls: investigate regtest performance on linux-arm builder #43355

findleyr opened this issue Dec 23, 2020 · 5 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.6.6

Comments

@findleyr
Copy link
Member

findleyr commented Dec 23, 2020 •
edited
Loading

The gopls regtests are slow, particularly on openbsd and darwin due to (we believe) kernel locking behavior. For this reason we've excluded them when testing with -short on several builders where they regularly time out.

But they usually run relatively quickly on Linux, so it's surprising (to me at least) that they are timing out on the new linux-arm builder. This is probably worth investigating at some point.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 23, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 23, 2020
@findleyr findleyr modified the milestones: Unreleased, gopls/unplanned Dec 23, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/280092 mentions this issue: gopls/internal/regtest: skip a some new builders where regtests time out

gopherbot pushed a commit to golang/tools that referenced this issue Dec 23, 2020
@findleyr
gopls/internal/regtest: skip a some new builders where regtests time out
3e0a2b7 
Updates golang/go#42789
Updates golang/go#43355

Change-Id: Ic344237e492b08c30c4d86db6a6a39a561e2d27b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/280092
Run-TryBot: Robert Findley <rfindley@google.com>
Trust: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@dmitshur
Copy link
Contributor

dmitshur commented Dec 23, 2020 •
edited
Loading

Do you know about the regtest performance on the linux-arm-aws builder?

The linux-arm builder is not new, has a known issue and is known to be slow (we disabled trybots because of many problems). The linux-arm-aws builder is newer (#41867) and has more resources allocated, so you may get a better signal about gopls behavior on linux/arm from it.

CC @cagedmantis.

@findleyr
Copy link
Member Author

Ah I see, I probably only noticed the linux-arm failure due to recent awareness of other failures (particularly openbsd).

I can try out the linux-arm-aws builder in 2021.

@findleyr
Copy link
Member Author

No issues on linux-arm-aws, so I think this is simply that the linux-arm builder is too small for gopls regtests.

Closing in favor of #32834.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/291469 mentions this issue: gopls/internal/regtest: exit if small machine

@golang golang locked and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.6.6
Development

No branches or pull requests
4 participants
@dmitshur @stamblerre @gopherbot @findleyr